release: prepare 2.0.0-rc7 - #122
Open
davidp57 wants to merge 1 commit into
Open
Conversation
Bump ctld.VERSION to 2.0.0-rc7 and draft the community release notes. Scope since rc6: 33 commits, 14 of them touching src/, in 17 lots. Seven in-mission fixes - two of which silently destroyed deployed objects (parachuted groups sharing a template deleting each other, AA system parts spawning on top of one another) - plus the i18n chain that gives FR/ES/KO their menus back: 56 labels wrongly dropped from the dictionaries, and the KO/ES translations that had never been written (70 per language, plus 29 surfaced by that fix). ctld-tools changes in one lot only, FEAT-CUSTOM-BEACON-SOUNDS: a Default/Custom picker for the two beacon sound settings, the chosen .ogg written into the .miz with its resource key and preload trigger. The notes open on the re-install notice: the engine travels inside the .miz, so a mission installed with rc6 keeps the old one until it is installed again. CHANGELOG untouched by design - [Unreleased] stays open on a pre-release (docs/developer/workflow.md), which is also why its reorganisation waits for the stable tag. CTLD.lua is git-ignored since CHORE-UNTRACK-BUILT-ENGINE (PR #110) and rebuilt by CI, so it is not committed here.
davidp57
added
the
skip-changelog
Reviewer's GuidePre-release prep for 2.0.0-rc7: bump the internal ctld.VERSION and overhaul RELEASE_NOTES.md to cover the latest in-mission fixes, i18n work, and ctld-tools beacon sound feature, plus updated installation/reinstall guidance and mission-maker notes, with no behavioral changes beyond what is already in develop. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="RELEASE_NOTES.md" line_range="54-55" />
<code_context>
-No setting added, renamed or removed. The engine is rc5's apart from its version stamp — everything
-in this release is in the tool and the documentation.
+- **The translated menus are whole again.** 56 labels — every HAWK, BUK, KUB, NASAMS, Patriot and
+ S-300 component, several crate, smoke and vehicle entries, and the category headers (Infantry, Air
+ Defense, Ground Vehicles, Helicopters, Aircraft, Ships, FARP / FOB) — had been dropped from the
+ dictionaries by a tooling bug and were falling back to English. If you fly in French, Spanish or
</code_context>
<issue_to_address>
**issue (typo):** Pluralize "crate" in "several crate, smoke and vehicle entries".
"Several" should be followed by a plural noun, so "crate" needs to be changed to "crates" to be grammatically correct.
```suggestion
- **The translated menus are whole again.** 56 labels — every HAWK, BUK, KUB, NASAMS, Patriot and
S-300 component, several crates, smoke and vehicle entries, and the category headers (Infantry, Air
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+54
to
+55
| - **The translated menus are whole again.** 56 labels — every HAWK, BUK, KUB, NASAMS, Patriot and | ||
| S-300 component, several crate, smoke and vehicle entries, and the category headers (Infantry, Air |
There was a problem hiding this comment.
issue (typo): Pluralize "crate" in "several crate, smoke and vehicle entries".
"Several" should be followed by a plural noun, so "crate" needs to be changed to "crates" to be grammatically correct.
Suggested change
| - **The translated menus are whole again.** 56 labels — every HAWK, BUK, KUB, NASAMS, Patriot and | |
| S-300 component, several crate, smoke and vehicle entries, and the category headers (Infantry, Air | |
| - **The translated menus are whole again.** 56 labels — every HAWK, BUK, KUB, NASAMS, Patriot and | |
| S-300 component, several crates, smoke and vehicle entries, and the category headers (Infantry, Air |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares the
2.0.0-rc7pre-release:ctld.VERSIONbumped andRELEASE_NOTES.mddrafted for the DCS community. No behaviour change — everything shipping in this rc is already ondevelop.Scope since rc6: 33 commits, 14 of them touching
src/, across 17 lots.UX-FASTROPE-INFLIGHTis deliberately absent from the notes: only its backlog index line landed after rc6, the feature itself already shipped in it.What the notes cover
Seven in-mission fixes, two of which silently destroyed deployed objects:
FIX-PARACHUTE-GROUP-NAME-COLLISION, fix(troops): unique DCS names for parachuted groups #103)FIX-AASYSTEM-UNPACK-BUGS, fix(aasystem): refresh unpack menu and fix unit overlap after assembly #101)onUnitDeadnever firing (FIX-FIELD-EXTRACT-CASUALTIES, fix(troop): field extraction reflects real casualties (FIX-FIELD-EXTRACT-CASUALTIES) #111)FIX-MENU-DOUBLE-MULTICREW, fix(menu): F10 menu duplication and multi-crew menu loss #106)The i18n chain (#115→#121), which gives FR/ES/KO their menus back: 56 labels wrongly dropped from the dictionaries by a tooling bug, and the KO/ES translations that had never been written (70 per language, plus 29 surfaced by that fix).
One
ctld-toolschange:FEAT-CUSTOM-BEACON-SOUNDS(#112) — a Default/Custom picker for the two beacon sound settings, the chosen.oggwritten into the.mizwith its resource key and preload trigger.Filtered out of the community notes as internal: the dev build channel (#109), untracking the built engine (#110), the i18n tooling lots (#118, #121), documentation and backlog bookkeeping.
Two deliberate choices
CHANGELOG.mdis untouched.[Unreleased]stays open on a pre-release (docs/developer/workflow.md) — only a stable freezes it. That is also why its reorganisation waits for the stable tag rather than happening here: every lot merged until then adds lines to it.CTLD.luais not committed. It has been git-ignored sinceCHORE-UNTRACK-BUILT-ENGINE(chore: untrack the built engine (CHORE-UNTRACK-BUILT-ENGINE) #110) and CI rebuilds it for the release. Thereleaseskill still says to commit it — stale on that point, worth a follow-up fix.The notes open on a re-install notice: the engine travels inside the
.miz, so a mission installed with rc6 keeps the old one until it is installed again. Without it, a Mission Maker who already installed would see none of the above.Test plan
merge_CTLD.ps1rebuild —CTLD.lua(1 180 586 bytes) stampsctld.VERSION = "2.0.0-rc7", loads in Lua 5.1, no BOMctld-toolsneeds no separate bump: it readsctld.VERSIONas the single source of truth (resources.py:152), so the exe and its help link follow automaticallydocs.ymlpublishes the tagged version and leaveslatestalone for a pre-releasegenerate_i18n_dicts.ps1dry-runOKon all four dictionariespublished-v2.0.0-rc7to trigger the release workflow (maintainer action)Summary by Sourcery
Prepare the 2.0.0-rc7 pre-release with updated release notes and versioning.
New Features:
Enhancements:
Documentation:
Chores: