feat: Vue 3.6 Vapor mode support - #124
Open
Valian wants to merge 4 commits into
Open
Conversation
Move createApp/createSSRApp from hooks.ts into defaultSetup in app.ts, removing createApp from SetupContext. Users who want Vapor mode can now provide their own setup function with vaporInteropPlugin. Also fixes the ssr flag which was previously hardcoded to false. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Update vue_index_content setup to import createApp from vue directly instead of destructuring from SetupContext - Pin all @vue/* packages to 3.6.0-beta.7 with overrides for peer dep resolution during beta period - Bump @vitejs/plugin-vue to ^6.0.4 for Vue 3.6 compatibility - Update SSR vite config to bundle Vue packages and use ESM conditions, fixing @vue/runtime-vapor SSR imports - Add comment about enabling Vapor mode in generated setup Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
|
Blocked on Vue 3.6 stable release. Most of the
Before merging, wait for Vue 3.6 stable, then clean up |
Remove defaultSetup and all Vue app factory imports from library source files. The user's setup function (always generated by the installer) now fully controls which Vue factories are imported, enabling proper tree-shaking for Vapor-only setups. - Remove defaultSetup from app.ts, make setup required in LiveVueOptions - Remove unused createSSRApp import from server.ts - Fix installer's generated setup to use ssr flag with createSSRApp Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add runtime check for initializeApp before passing to createLiveVue, satisfying the now-required setup parameter type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createApp/createSSRAppfromSetupContext, moving them intodefaultSetupinapp.tssetupwithvaporInteropPluginssrflag inSetupContextwhich was hardcoded tofalse— now truthfully reflectsdata-ssrattributeBreaking change
SetupContext.createAppis removed. Users with a customsetupfunction that destructuredcreateAppfrom context need to import it fromvuedirectly.Test plan
vaporInteropPlugin🤖 Generated with Claude Code