implement env_rain & env_snow like the original CS

[hasandramali]

I know you guys don't like me, so i won't get into personal stuff here.
The rain and snow effects in PC CS added a lot to the game's atmosphere; I think it would be great if you included small details like that so i think it's definitely worth working on...

particleman prototype:

8mb.video-3od-IyDIeOyf.mp4

[a1batross]

Can you remove old rain code too?

[Vladislav4KZ]

Before creating the PR, could you clean up the unnecessary commits?

You created a file, added some code, and then removed it again later. I don't really see why that was necessary.

[a1batross]

Before creating the PR, could you clean up the unnecessary commits?

You created a file, added some code, and then removed it again later. I don't really see why that was necessary.

yeah, agree here. In the worst case it can be squash merged, so none of this is going to be in history.

[Vladislav4KZ]

@hasandramali Do you know how to use git?

You should have used git reset --soft HEAD~N, where N is the number of your commits, to roll back while keeping the changes.

Then you could make a new commit, or a few commits related to integrating particleman for weather effects.

After that, run git push -u origin <your-branch> --force to force-push your branch with a cleaned-up commit history.

[Vladislav4KZ]

Also, commit messages should be formatted like this: folder: file: commit message or file: commit message. You can check our commit history as an example.

[Vladislav4KZ]

I still see the old commits in your branch.

[hasandramali]

Sorry about that, this is my first time making a pull request. Did it work now?

[Vladislav4KZ]

Sorry about that, this is my first time making a pull request. Did it work now?

You also changed the commit message for the mainui_cpp submodule, which shouldn’t have been modified. You should have only committed your changes.

[a1batross]

Also, it seems particleman and environment logic has been taken from halflife-updated and hlsdk-featureful.

It would be nice to add proper attribution for the authors for this code.

[a1batross]

Again, drop all changes in 3rdparty.

[hasandramali]

I was late in fixing the PR due to sudden internet outages. is it okay now?

[a1batross]

Looks ok to me. Need some cleanup, but I think it can be done later.

What's your thoughts @Vladislav4KZ?

[hasandramali]

Apologies, I missed updating a few minor values for snow distance & snow rate. Everything is all set now.

[Vladislav4KZ]

@a1batross I think it can be merged.

[a1batross]

Once build finishes, I will merge it.

@hasandramali thanks, good job!