feat(ui): Einstellungen im Pausemenü, ohne die Partie zu verlassen - #117
Merged
Conversation
Owner request after the T-03 play round: changing the volume meant leaving the match. The pause menu now carries the same settings the main menu owns — music and SFX each with on/off + volume slider, fullscreen toggle and a resolution cycle — all writing through the shared GameSettingsStore gateway (ApplyAndSave): applied immediately, persisted to the same settings.json, no duplicated state. The earlier 'settings live in the main menu' hint is superseded by the owner decision. Verified: Nova.Presentation.UI builds clean; Unity EditMode 615/615. Play-side check (slider audibility, panel height with the section open) is on the manual list — OnGUI rows have no automated click path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was
Nachtrag zu Paket 21.8 aus Sprint 21, auf Inhaber-Wunsch nach der Proberunde T-03: wer die Lautstärke ändern wollte, musste die Partie verlassen.
Das Pausemenü trägt jetzt dieselben Einstellungen, die bisher nur die Hauptmenü-Maske hatte:
Warum es kein zweiter Zustand ist
Beide Oberflächen schreiben über dasselbe Gateway —
GameSettingsStore.ApplyAndSave. Die Einstellung wirkt sofort und persistiert in dieselbesettings.json; es entsteht kein zweiter Satz Wahrheit, der mit dem ersten auseinanderlaufen könnte. Der frühere Hinweis „Einstellungen leben im Hauptmenü" ist damit überholt und entfernt.Nachweis
dotnet test tools/Nova.SimRunner.Tests -c Release: grün (reine Präsentationsänderung, die headless-Kette kompiliertPresentation/nicht mit)OnGUI-Zeilen haben keinen Klickpfad im Test — steht auf der manuellen Liste.Betroffene Bereiche
Presentation/UI/PauseMenuHud.cs,CHANGELOG.md. Kein Simulationseingriff, keine Baseline-Bewegung.