fix(axis): align rotated text OBB offsets - #2106
Merged
Merged
Conversation
xuefei1313
marked this pull request as ready for review
July 29, 2026 08:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dx/dy, then apply those offsets as world-space translation.flush: truewith greedy auto-hide and vertically rotated endpoint labels.Root cause
Text rendering applies
dx/dyafter rotation. The OBB path included those offsets before rotating its measurement box, so its collision geometry diverged from the rendered text AABB and missed overlapping endpoint labels.Validation
packages/vrender-core: Jest suite — 105 suites passed, 613 tests passedpackages/vrender-components: LineAxis electron regression suite — 12 tests passedrush compile -t @visactor/vrender-core -t @visactor/vrender-componentsrush test --only tag:packagehook