Skip to content

feat: add support secret list#73

Merged
gorkarevilla merged 7 commits into
mainfrom
APIAPEX-2707/get_secrets
May 13, 2026
Merged

feat: add support secret list#73
gorkarevilla merged 7 commits into
mainfrom
APIAPEX-2707/get_secrets

Conversation

@gorkarevilla

@gorkarevilla gorkarevilla commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a new vcr secret list command (aliased as vcr secret ls) that displays the names of all secrets stored in a VCR account. Secret values are never exposed.

Changes

  • New command: vcr secret list / vcr secret ls
  • Fetches secrets via the existing DeploymentClient().ListSecrets() API
  • Displays a count and the name of each secret
  • Shows a warning when no secrets are found

Example

$ vcr secret list
⠋ Fetching secrets...
✓ Found 3 secret(s):
  ℹ MY_API_KEY
  ℹ DATABASE_PASSWORD
  ℹ SSL_CERT

When no secrets exist:

$ vcr secret list
⚠ No secrets found

The ls alias also works:

$ vcr secret ls
✓ Found 3 secret(s):
  ℹ MY_API_KEY
  ℹ DATABASE_PASSWORD
  ℹ SSL_CERT

Example with smokes accounts (contains lot of secrets):

╰  ./vcr_macos_arm64 secret list
✓ Found 14259 secret(s):
  ℹ qa_smoke_deploymnt_scrt_euw1_1_1_640c7a1e
  ℹ qa_smoke_deploymnt_scrt_euw1_1_2_640c7a1e
  ℹ qa_smoke_deploymnt_scrt_euw1_1_1_a9e7187b
  ℹ qa_smoke_deploymnt_scrt_euw1_1_2_a9e7187b
  ℹ qa_smoke_deploymnt_scrt_euw1_1_1_d9660304
  ℹ qa_smoke_deploymnt_scrt_euw1_1_2_d9660304
  ℹ qa_smoke_deploymnt_scrt_euw1_1_1_ed3bfc88
  ℹ qa_smoke_deploymnt_scrt_euw1_1_2_ed3bfc88
  ℹ qa_smoke_deploymnt_scrt_euw1_1_1_bed55f5c
  ℹ qa_smoke_deploymnt_scrt_euw1_1_2_bed55f5c
  ℹ qa_smoke_deploymnt_scrt_euw1_1_1_29a775d2
  ℹ qa_smoke_deploymnt_scrt_euw1_1_2_29a775d2
  ℹ qa_smoke_deploymnt_scrt_euw1_1_1_68e7ba76
  ℹ qa_smoke_deploymnt_scrt_euw1_1_2_68e7ba76
  ℹ qa_smoke_deploymnt_scrt_euw1_1_1_daf61a12
  ℹ qa_smoke_deploymnt_scrt_euw1_1_2_daf61a12
  ℹ qa_smoke_deploymnt_scrt_euw1_1_1_21e2a80b
  ℹ qa_smoke_deploymnt_scrt_euw1_1_2_21e2a80b
  ℹ qa_smoke_deploymnt_scrt_euw1_1_1_ecc49881
  ℹ qa_smoke_deploymnt_scrt_euw1_1_2_ecc49881
....

@gorkarevilla gorkarevilla requested a review from Copilot March 19, 2026 07:34
@gorkarevilla gorkarevilla changed the title APIAPEX-2708: add support secret list feat: add support secret list Mar 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for listing secrets in the VCR CLI by introducing a new vcr secret list subcommand, wiring it into the secret command group, and extending the deployment API/client interface to support a secrets listing endpoint.

Changes:

  • Add vcr secret list (alias ls) command with CLI output for secret names.
  • Extend DeploymentInterface + mocks, and implement DeploymentClient.ListSecrets() against GET /secrets.
  • Add unit tests for both the CLI command and the API client.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
vcr/secret/secret.go Registers the new list subcommand and updates help text.
vcr/secret/list/list.go Implements the new secret list command and its output.
vcr/secret/list/list_test.go Adds CLI unit tests for the new command.
pkg/cmdutil/factory.go Extends DeploymentInterface with ListSecrets.
pkg/api/deployment.go Implements DeploymentClient.ListSecrets() using the REST endpoint.
pkg/api/deployment_test.go Adds API client unit tests for ListSecrets.
testutil/mocks/factory.go Regenerates mocks to include ListSecrets.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread vcr/secret/list/list.go
Comment thread vcr/secret/list/list_test.go
Comment thread pkg/api/deployment.go
gorkarevilla and others added 5 commits May 11, 2026 16:24
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: APIAPEX-2747 add follow flag to instance logs

* test: add tests

@sichan-vonage sichan-vonage left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM make sure not to release it before deployment-api has been deployed

@gorkarevilla gorkarevilla merged commit 8350a42 into main May 13, 2026
9 checks passed
@gorkarevilla gorkarevilla deleted the APIAPEX-2707/get_secrets branch May 13, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants