feat(app): add vcr app remove command [APIAPEX-2823]

.gitignore

@@ -17,3 +17,6 @@ lefthook-local.yml
 
 # Node modules (for commitlint)
 node_modules/
+
+# Agent working files
+docs/superpowers/

pkg/api/deployment.go

@@ -5,6 +5,7 @@ import (
 	"context"
 	"fmt"
 	"net/http"
+	"net/url"
 	"regexp"
 	"strings"
 
@@ -106,6 +107,22 @@ func (c *DeploymentClient) GenerateVonageApplicationKeys(ctx context.Context, ap
 	return nil
 }
 
+func (c *DeploymentClient) DeleteVonageApplication(ctx context.Context, appID string) error {
+	resp, err := c.httpClient.R().
+		SetContext(ctx).
+		Delete(c.baseURL + "/applications/" + url.PathEscape(appID))
+	if err != nil {
+		return fmt.Errorf("%w: trace_id = %s", err, traceIDFromHTTPResponse(resp))
+	}
+	if resp.StatusCode() == http.StatusNotFound {
+		return ErrNotFound
+	}
+	if resp.IsError() {
+		return NewErrorFromHTTPResponse(resp)
+	}
+	return nil
+}
+
 type deployRequest struct {
 	Runtime          string       `json:"runtime"`
 	Region           string       `json:"region"`

pkg/api/deployment_test.go

@@ -239,6 +239,80 @@ func TestGenerateVonageApplicationKeys(t *testing.T) {
 	}
 }
 
+func TestDeleteVonageApplication(t *testing.T) {
+	client := resty.New()
+	httpmock.ActivateNonDefault(client.GetClient())
+	defer httpmock.DeactivateAndReset()
+
+	type mock struct {
+		mockResponse string
+		status       int
+	}
+
+	type want struct {
+		err error
+	}
+
+	tests := []struct {
+		name string
+		mock mock
+		want want
+	}{
+		{
+			name: "204-happy-path",
+			mock: mock{
+				mockResponse: "",
+				status:       http.StatusNoContent,
+			},
+			want: want{
+				err: nil,
+			},
+		},
+		{
+			name: "404-not-found",
+			mock: mock{
+				mockResponse: "",
+				status:       http.StatusNotFound,
+			},
+			want: want{
+				err: ErrNotFound,
+			},
+		},
+		{
+			name: "500-error",
+			mock: mock{
+				mockResponse: `{"error": {"code": 1001, "message": "internal server error", "traceId": "n/a", "containerLogs": ""}}`,
+				status:       http.StatusInternalServerError,
+			},
+			want: want{
+				err: errors.New("API Error Encountered: ( HTTP status: 500 Error code: 1001 Detailed message: internal server error Trace ID: n/a )"),
+			},
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+
+			httpmock.RegisterResponder("DELETE", "https://example.com/v0.3/applications/application-id",
+				func(_ *http.Request) (*http.Response, error) {
+					resp := httpmock.NewStringResponse(tt.mock.status, tt.mock.mockResponse)
+					resp.Header.Set("Content-Type", "application/json")
+					return resp, nil
+				})
+
+			deploymentClient := NewDeploymentClient("https://example.com", "v0.3", client, nil)
+
+			err := deploymentClient.DeleteVonageApplication(t.Context(), "application-id")
+			if tt.want.err != nil {
+				require.EqualError(t, err, tt.want.err.Error())
+				httpmock.Reset()
+				return
+			}
+			require.NoError(t, err)
+			httpmock.Reset()
+		})
+	}
+}
+
 func TestDeployDebugService(t *testing.T) {
 	client := resty.New()
 	httpmock.ActivateNonDefault(client.GetClient())

pkg/cmdutil/factory.go

@@ -40,6 +40,7 @@ type DeploymentInterface interface {
 	CreateVonageApplication(ctx context.Context, name string, enableRTC, enableVoice, enableMessages bool) (api.CreateVonageApplicationOutput, error)
 	ListVonageApplications(ctx context.Context, filter string) (api.ListVonageApplicationsOutput, error)
 	GenerateVonageApplicationKeys(ctx context.Context, appID string) error
+	DeleteVonageApplication(ctx context.Context, appID string) error
 	DeployDebugService(ctx context.Context, region, applicationID, name string, caps api.Capabilities) (api.DeployResponse, error)
 	GetServiceReadyStatus(ctx context.Context, serviceName string) (bool, error)
 	DeleteDebugService(ctx context.Context, serviceName string, preserveData bool) error

vcr/app/app.go

@@ -8,6 +8,7 @@ import (
 	createCmd "vonage-cloud-runtime-cli/vcr/app/create"
 	generatekeysCmd "vonage-cloud-runtime-cli/vcr/app/generatekeys"
 	listCmd "vonage-cloud-runtime-cli/vcr/app/list"
+	removeCmd "vonage-cloud-runtime-cli/vcr/app/remove"
 )
 
 func NewCmdApp(f cmdutil.Factory) *cobra.Command {
@@ -27,6 +28,7 @@ func NewCmdApp(f cmdutil.Factory) *cobra.Command {
 
 			AVAILABLE COMMANDS
 			  create         Create a new Vonage application
+			  remove (rm)    Remove a Vonage application
 			  list (ls)      List all Vonage applications in your account
 			  generate-keys  Generate new key pairs for an existing application
 
@@ -39,19 +41,23 @@ func NewCmdApp(f cmdutil.Factory) *cobra.Command {
 			# Create a new application with Voice and Messages capabilities
 			$ vcr app create --name my-app --voice --messages
 
+			# Remove an application
+			$ vcr app remove 12345678-1234-1234-1234-123456789abc
+
+			# Generate new keys for an existing application
+			$ vcr app generate-keys --app-id 12345678-1234-1234-1234-123456789abc
+
 			# List all applications
 			$ vcr app list
 
 			# List applications filtered by name
 			$ vcr app list --filter "production"
-
-			# Generate new keys for an existing application
-			$ vcr app generate-keys --app-id 12345678-1234-1234-1234-123456789abc
 		`),
 	}
 
-	cmd.AddCommand(listCmd.NewCmdAppList(f))
 	cmd.AddCommand(createCmd.NewCmdAppCreate(f))
 	cmd.AddCommand(generatekeysCmd.NewCmdAppGenerateKeys(f))
+	cmd.AddCommand(listCmd.NewCmdAppList(f))
+	cmd.AddCommand(removeCmd.NewCmdAppRemove(f))
 	return cmd
 }

vcr/app/remove/remove.go

@@ -0,0 +1,90 @@
+package remove
+
+import (
+	"context"
+	"errors"
+	"fmt"
+
+	"github.com/MakeNowJust/heredoc"
+	"github.com/spf13/cobra"
+
+	"vonage-cloud-runtime-cli/pkg/api"
+	"vonage-cloud-runtime-cli/pkg/cmdutil"
+)
+
+type Options struct {
+	cmdutil.Factory
+
+	ApplicationID string
+	SkipPrompts   bool
+}
+
+func NewCmdAppRemove(f cmdutil.Factory) *cobra.Command {
+	opts := Options{
+		Factory: f,
+	}
+
+	cmd := &cobra.Command{
+		Use:     "remove <applicationID>",
+		Aliases: []string{"rm"},
+		Short:   "Remove a Vonage application",
+		Long: heredoc.Doc(`Remove a Vonage application from your account.
+
+			This command permanently removes a Vonage application and its associated
+			credentials. Any VCR instances linked to this application will lose their
+			authentication credentials on next restart.
+
+			WARNING: This action is irreversible. Make sure no running instances
+			depend on this application before removing it.
+		`),
+		Example: heredoc.Doc(`
+			# Remove an application (will prompt for confirmation)
+			$ vcr app remove 12345678-1234-1234-1234-123456789abc
+
+			# Remove without confirmation prompt (useful for CI/CD)
+			$ vcr app remove 12345678-1234-1234-1234-123456789abc --yes
+
+			# Using the short alias
+			$ vcr app rm 12345678-1234-1234-1234-123456789abc --yes
+		`),
+		Args: cobra.ExactArgs(1),
+		RunE: func(_ *cobra.Command, args []string) error {
+			opts.ApplicationID = args[0]
+
+			ctx, cancel := context.WithDeadline(context.Background(), opts.Deadline())
+			defer cancel()
+
+			return runRemove(ctx, &opts)
+		},
+	}
+
+	cmd.Flags().BoolVarP(&opts.SkipPrompts, "yes", "y", false, "Skip confirmation prompt (use with caution)")
+
+	return cmd
+}
+
+func runRemove(ctx context.Context, opts *Options) error {
+	io := opts.IOStreams()
+	c := io.ColorScheme()
+
+	if io.CanPrompt() && !opts.SkipPrompts {
+		if !opts.Survey().AskYesNo(fmt.Sprintf("Are you sure you want to remove application %q?", opts.ApplicationID)) {
+			fmt.Fprintf(io.ErrOut, "%s Application removal aborted\n", c.WarningIcon())
+			return nil
+		}
+	}
+
+	spinner := cmdutil.DisplaySpinnerMessageWithHandle(fmt.Sprintf(" Removing application %q...", opts.ApplicationID))
+	err := opts.DeploymentClient().DeleteVonageApplication(ctx, opts.ApplicationID)
+	spinner.Stop()
+	if err != nil {
+		if errors.Is(err, api.ErrNotFound) {
+			return fmt.Errorf("application %q could not be found or may have already been deleted", opts.ApplicationID)
+		}
+		return fmt.Errorf("failed to remove application: %w", err)
+	}
+
+	fmt.Fprintf(io.Out, "%s Application %q successfully removed\n", c.SuccessIcon(), opts.ApplicationID)
+
+	return nil
+}