Support for new audio transport header in AudioConnector#352
Open
alfonso-soto wants to merge 2 commits into
Open
Support for new audio transport header in AudioConnector#352alfonso-soto wants to merge 2 commits into
alfonso-soto wants to merge 2 commits into
Conversation
superchilled
left a comment
superchilled
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. I just have one small question/comment about the use of serialization_alias for some of the fields in the AudioTransportConfig model.
Comment on lines
+25
to
+29
| audio_field: Optional[str] = Field(None, serialization_alias='audio_field') | ||
| receive_audio_field: Optional[str] = Field( | ||
| None, serialization_alias='receive_audio_field' | ||
| ) | ||
| static_fields: Optional[dict] = Field(None, serialization_alias='static_fields') |
Contributor
There was a problem hiding this comment.
I'm not too clear on the reason for setting a serialization_alias on these three fields, since the value set for serialization_alias in each case is identical to the actual field name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.