Support Apple Silicon via CoreML - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances device selection logic for inference and adds comprehensive tests for provider selection. The main improvements are support for Apple's CoreML as a provider, improved handling of the
--cpuonlyflag, and a new test suite to verify provider selection behavior.Device/provider selection improvements:
--cpuonlyargument help text to clarify that it disables both CUDA and CoreML providers, not just CUDA.get_providersfunction incli.pyto:--cpuonlyflag to always force CPU, regardless of other providers.Test coverage:
TestGetProviderstest class intests/test_infer_functions.pyto cover all combinations of provider availability and environment overrides, ensuring correct provider selection logic.get_providersinto the test file for direct testing.Please note that there is E5RT-related logspam that this PR doesn't suppress--the issue it identifies does not affect performance or output.