Skip to content

add not_modified_since option to list_bins endpoint #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mike-kaimika wants to merge 1 commit into
base: restore-improved-list-bins-endpoint
Choose a base branch
from
Open

add not_modified_since option to list_bins endpoint #540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ifcbdb/dashboard/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1371,6 +1371,12 @@ def list_bins(request):
except (ValueError, TypeError):
return HttpResponseBadRequest("Invalid modified_since date")

not_modified_since = request.GET.get('not_modified_since')
try:
not_modified_since = pd.to_datetime(not_modified_since, utc=True)
except (ValueError, TypeError):
return HttpResponseBadRequest("Invalid not_modified_since date")

tags = request_get_tags(request.GET.get('tags'))
instrument_number = request_get_instrument(request.GET.get('instrument'))
cruise = request_get_cruise(request.GET.get('cruise'))
Expand Down Expand Up @@ -1404,6 +1410,9 @@ def list_bins(request):
if modified_since:
bin_qs = bin_qs.filter(modified__gt=modified_since)

if not_modified_since:
bin_qs = bin_qs.filter(modified__lt=not_modified_since)

bin_qs = bin_qs.order_by('sample_time')

bins = list(bin_qs.values('pid', 'sample_time')[:MAX_BINS])
Expand Down