fix: make menu conditions dynamic and optimize accessibility check - #83
Open
SarthakDudhe wants to merge 1 commit into
Open
fix: make menu conditions dynamic and optimize accessibility check#83SarthakDudhe wants to merge 1 commit into
SarthakDudhe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic Navigation Menu Path Opening: We replaced the static length checks (depth of 2 or 3) with a helper function togglePathKeys that recursively/iteratively toggles the menu expansion state (openSet) for all dot-separated keys in splitPath. This dynamically supports menus of any arbitrary nesting depth.
Short-Circuit Accessibility Check: We optimized menuFunction's child permission check. Instead of using .map(), which checks all children regardless of match, we now use .some() to return early (true) as soon as any child menu with valid access is found.