Skip to content

Generate: improve empty, loading, and error states#303

Merged
WalksWithASwagger merged 1 commit into
mainfrom
codex/issue-296-generate-improve-empty-loading-and-error-states
Jul 3, 2026
Merged

Generate: improve empty, loading, and error states#303
WalksWithASwagger merged 1 commit into
mainfrom
codex/issue-296-generate-improve-empty-loading-and-error-states

Conversation

@WalksWithASwagger

Copy link
Copy Markdown
Owner

Summary

  • Split Generate route status into distinct validation, loading, generation/backend failure, and notice states.
  • Added explicit empty/loading/unavailable panels for library references, media references, selected references, prompt preview, and route loading.
  • Preserved safe backend detail handling while avoiding resolved filesystem paths in missing prompt-file errors.
  • Extended portal smoke coverage for validation refusal before /api/regen and missing prompt-preview errors.

Closes #296

Verification

  • npm run frontend:verify (passes; existing fast-refresh warnings in shared UI files remain)
  • python3 -m pytest tests/test_server_generate.py tests/test_server_endpoints.py -q (37 passed)
  • npm run e2e:portal (passes)
  • git diff --check (passes)

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Agentic PR Review

Verdict: needs-human

Checks:

  • Linked issue via Closes #... or Refs #...: yes
  • Issue acceptance criteria found: 13
  • PR verification section present: yes
  • PR acceptance self-check present: no
  • Diff within v1 limits: yes

This PR is not blocked from human review, but the agentic gate is not satisfied.

@github-actions github-actions Bot added the needs-human Agentic automation stopped for human judgment. label Jul 3, 2026
@WalksWithASwagger WalksWithASwagger marked this pull request as ready for review July 3, 2026 22:53
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Agentic PR Review

Verdict: needs-human

Checks:

  • Linked issue via Closes #... or Refs #...: yes
  • Issue acceptance criteria found: 13
  • PR verification section present: yes
  • PR acceptance self-check present: no
  • Diff within v1 limits: yes

This PR is not blocked from human review, but the agentic gate is not satisfied.

1 similar comment
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Agentic PR Review

Verdict: needs-human

Checks:

  • Linked issue via Closes #... or Refs #...: yes
  • Issue acceptance criteria found: 13
  • PR verification section present: yes
  • PR acceptance self-check present: no
  • Diff within v1 limits: yes

This PR is not blocked from human review, but the agentic gate is not satisfied.

@WalksWithASwagger WalksWithASwagger force-pushed the codex/issue-296-generate-improve-empty-loading-and-error-states branch from 0620571 to 17eeb29 Compare July 3, 2026 23:15
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Agentic PR Review

Verdict: needs-human

Checks:

  • Linked issue via Closes #... or Refs #...: yes
  • Issue acceptance criteria found: 13
  • PR verification section present: yes
  • PR acceptance self-check present: no
  • Diff within v1 limits: yes

This PR is not blocked from human review, but the agentic gate is not satisfied.

@WalksWithASwagger WalksWithASwagger merged commit e2a0a8a into main Jul 3, 2026
5 checks passed
@WalksWithASwagger WalksWithASwagger deleted the codex/issue-296-generate-improve-empty-loading-and-error-states branch July 3, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human Agentic automation stopped for human judgment.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate: improve empty, loading, and error states

1 participant