feat: add branch/pr cleanup methods to GitHubClient - #394
Merged
Conversation
find_open_pull_for_branch, close_pull, delete_branch -- needed to let the dataset-proposal flow tell a stale leftover branch apart from a real conflict and clean it up on override.
|
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds `find_open_pull_for_branch`, `close_pull`, and `delete_branch` to `GitHubClient`, plus a small `_send`/`_request`/`_request_list` refactor so list and no-content responses (GET pulls, DELETE ref) share the same error handling as the existing dict-returning calls.
Why: the dataset-proposal flow currently treats "the proposal branch already exists" as a single hard conflict, even when the branch is just a leftover from an earlier, abandoned/closed proposal (the dataset was never actually registered). These methods are the building blocks the next PR uses to detect that case and clean it up: look up whether the branch still has an open PR, close it if so, then delete the branch.
Benefit: no new behavior yet (nothing calls these methods from the proposal flow in this PR) — just tested, isolated primitives the next PR in the stack wires up.