apply irradiance scale to more MicaSense cameras - #38
Merged
Conversation
Expand camera model check for MicaSense to include RedEdge-M, Altum, and Altum-PT.
Member
|
Thanks @n-grieger ! I think the proposed approach works best, as we can't assume all MicaSense cameras (current and future) follow this convention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extension of #36
I have checked the other Micasense camera models with sample data in the micasense repository (see https://github.com/micasense/imageprocessing/tree/master/data). Similar to our RedEdge-P data, the other cameras are also missing the Camera:HorizontalIrradiance tag and use the x100 scaling. This PR should hopefully fix future problems with any of these cameras. We could also think about reducing the check to just
elif self.camera_make == "MicaSense"in the hope that Micasense doesn't decide to change their data handling in future cameras.