You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No worries.
To be clear the only reason for this pull request is http schema.
If you like I can change it so the user would have the option to choose http/s but truly I think that this is a bad idea.
One might use this library for the first time without checking exactly what the code does and use it to search for some very sensitive information over say cyber API.
What do you think?
@idanmel I've thought about it and I think that there is no point in leaving the HTTP schema.
With the provided services your customers may search for very sensitive data, and some of them are probably doing it right now over the clear web.
I think it should be the other way around: you should help your users by enforcing them to use a more secure connection and if someone wants they'll be able to downgrade to HTTP after changing one line of code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.