fix: 헬스체크 경로 수정 및 이미지 정리 범위 한정#60
Merged
Woomin-Wang merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
Woomin-Wang
force-pushed
the
fix/docker-healthcheck-and-image-prune
branch
from
183db93 to
1c44095
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Dockerfile health check endpoint to use the Spring Boot Actuator path. Feedback was provided regarding the health check interval, which is currently set to 24 hours; this should be reduced to a more standard duration like 30 seconds to ensure timely failure detection.
| # 컨테이너 레벨 헬스체크 (Docker daemon의 status 표시용) | ||
| HEALTHCHECK --interval=24h --timeout=10s --start-period=40s --retries=3 \ | ||
| CMD curl -sf http://localhost:7300/health || exit 1 | ||
| CMD curl -sf http://localhost:7300/actuator/health || exit 1 |
There was a problem hiding this comment.
헬스체크 경로를 /actuator/health로 수정한 것은 적절합니다. 다만, 현재 HEALTHCHECK 설정의 interval이 24h(24시간)로 설정되어 있습니다(36번 라인). 이로 인해 컨테이너 시작 후 첫 번째 헬스체크가 24시간 뒤에나 수행되며, 장애 발생 시 감지 및 복구에 매우 긴 시간이 소요됩니다. 일반적으로 interval은 30s~1m 정도로 설정하는 것이 권장됩니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용 (Description)
/health→/actuator/health로 수정backend-java이미지만 삭제하도록reference필터 추가🔄 변경 유형 (Type of Change)
✅ 체크리스트 (Checklist)
💬 추가 코멘트 (Additional Comments)
기존
/health경로는 Spring Boot Actuator 기본 경로와 달라 헬스체크가 항상 실패하는 상태였습니다.이미지 정리 범위를 한정하지 않으면 TS 팀 이미지까지 삭제될 수 있어
reference필터로 대상을 명시했습니다.