Pulseaudio fixes#588
Conversation
…d/resume and audio focus
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e25c72eff8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "default-fragment-size-msec = " + options.fragmentMillis, | ||
| "")); | ||
| boolean lowLatency = Options.PERFORMANCE_MODE_LOW_LATENCY.equals(options.performanceMode); | ||
| String sinkParams = "volume=" + options.volume + " performance_mode=1"; |
There was a problem hiding this comment.
When a user leaves the PulseAudio mode at the default or sets WINNATIVE_PULSE_AAUDIO_PERFORMANCE_MODE=power_saving, this always writes performance_mode=1; the bundled module-aaudio-sink.so advertises 0 (NONE), 1 (Low Latency), 2 (Power Saving), so both default and power-saving sessions are forced into low-latency mode and the parsed option above is ignored. This can increase power use and make audio less stable on devices that intentionally select power-saving/default mode.
Useful? React with 👍 / 👎.
1 participant
Adopted GameNative PulseAudio stack to fix audio issues with "PulseAudio" specifically.
(( Yes we clearly credit where fixes / source comes from ))