Require revisions for local mutations - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
expectedRevisionon generic card updates, snooze, checklist creation, and checklist updates400, while stale revisions return409withcurrentRevisiondueAtas eitherYYYY-MM-DDor an offset-bearing ISO instant and rejects ambiguous offset-less date-timestask_eventsledger versus the prunableactivity_logfeedactions/checkout@v7andactions/setup-node@v6Why
The foundation exposed optimistic revisions everywhere but four local mutation paths allowed callers to omit them, letting an agent bypass concurrency protection. The audit and date models were also implemented but not explicit enough for clients and reviewers.
Impact
The existing web UI already sends current revisions on all affected paths, so normal board behavior is unchanged. Custom callers that omitted
expectedRevisionnow receive an actionable400and must reload before mutating. Rejected mutations do not create audit events.Validation
npm --workspace web run lintnpm test— 25 server tests and 13 web tests passednpm run build— server and web production builds passednpm run agent:smokepassedgit diff --checkpassed