Skip to content

Make app callable from commandl ine by just doing scdefg after pip installing.#3

Open
Munfred wants to merge 1 commit into
mainfrom
pip_command_line
Open

Make app callable from commandl ine by just doing scdefg after pip installing.#3
Munfred wants to merge 1 commit into
mainfrom
pip_command_line

Conversation

@Munfred

@Munfred Munfred commented Sep 12, 2021

Copy link
Copy Markdown
Collaborator

Should be good for pypi now

@valearna if these changes are good please merge to main and I'll put it on pypi

@Munfred Munfred requested a review from valearna September 12, 2021 20:13

@valearna valearna left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding entry_points to setup.py works beautifully when running the app from a terminal and both PR #3 and #4 look ok, but now I can't figure out how to run the app from gunicorn, a fundamental step in our deployment. I tried to add a wsgi file (as suggested here https://www.digitalocean.com/community/tutorials/how-to-serve-flask-applications-with-gunicorn-and-nginx-on-ubuntu-18-04) with the code that is now commented out at the bottom of app.py and this works fine. I can add this file to the PR and change the systemd configuration to point to the new file, but I wanted to hear if you had an alternative way to run the app with gunicorn before adding my changes. Also, should I commit them to #3 or to #4?

@Munfred

Munfred commented Sep 15, 2021

Copy link
Copy Markdown
Collaborator Author

I don't really know of a better way of deploying with Gunicorn. Let's make the changes to #4, it is cool to have external contributors. However, let's keep the command to be just scdefg, not scdefg-launch since we only have one command really.

@valearna

Copy link
Copy Markdown
Collaborator

Ok cool, I'll add the wsgi file to #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants