Pass -unattended to every commandlet invocation - #96
Open
marlonrichert wants to merge 1 commit into
Open
Conversation
marlonrichert
marked this pull request as draft
July 14, 2026 12:04
Contributor
Author
|
|
Contributor
Author
|
Found the cause: Passing |
_RunMakeBase() already passed -unattended, but _RunMakeMod() and _RunCookHL() didn't. Without it, the commandlet host might show an interactive "Scripts are outdated. Would you like to rebuild now?" dialog that blocks the build until a human clicks "No". -unattended suppresses this dialog. Note, though, that we shouldn't pass -unattended to precompileshaders, because that causes it to crash due to a bug in Firaxis's code. There is nothing we can do about that on our side.
marlonrichert
force-pushed
the
fix-unattended-commandlets
branch
from
July 14, 2026 12:53
9b57300 to
7f7b788
Compare
marlonrichert
marked this pull request as ready for review
July 14, 2026 12:57
Contributor
Author
|
Fixed and updated the description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_RunMakeBase() already passed -unattended, but _RunMakeMod() and
_RunCookHL() didn't. Without it, the commandlet host might show an
interactive "Scripts are outdated. Would you like to rebuild now?"
dialog that blocks the build until a human clicks "No". -unattended
suppresses this dialog.
Note, though, that we shouldn't pass -unattended to precompileshaders,
because that causes it to crash due to a bug in Firaxis's code. There is
nothing we can do about that on our side.