Skip to content

feat: Make DynamicMPT opt-in-immutable - #583

Open
yinyiqian1 wants to merge 12 commits into
XRPLF:masterfrom
yinyiqian1:update-dynamicmpt
Open

feat: Make DynamicMPT opt-in-immutable#583
yinyiqian1 wants to merge 12 commits into
XRPLF:masterfrom
yinyiqian1:update-dynamicmpt

Conversation

@yinyiqian1

@yinyiqian1 yinyiqian1 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

As describe in the title

Context of Change

Type of Change

  • New XLS Draft
  • XLS Update (changes to an existing XLS)
  • XLS Status Change (e.g., Draft → Final, Draft → Stagnant)
  • Process/Meta (changes to CONTRIBUTING.md, XLS-1, templates, etc.)
  • Infrastructure (CI, workflows, scripts, website)
  • Documentation (README updates, typo fixes)

@yinyiqian1
yinyiqian1 marked this pull request as ready for review July 17, 2026 20:22
pdp2121 added a commit to XRPLF/xrpl.js that referenced this pull request Aug 3, 2026
## High Level Overview of Change

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
If a relevant Asana task, please link it here.
-->
Spec change: XRPLF/XRPL-Standards#583

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
- [ ] Documentation Updates
- [ ] Release

### Did you update HISTORY.md?

- [ ] Yes
- [ ] No, this change does not impact library users## High Level Overview of Change

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
If a relevant Asana task, please link it here.
-->
Spec change: XRPLF/XRPL-Standards#583

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
- [ ] Documentation Updates
- [ ] Release

### Did you update HISTORY.md?

- [x] Yes
- [ ] No, this change does not impact library users
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
pdp2121 added a commit to XRPLF/xrpl-rust that referenced this pull request Aug 11, 2026
## High Level Overview of Change

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
If a relevant Asana task, please link it here.
-->
Spec change: XRPLF/XRPL-Standards#583

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Release

@Kassaking7 Kassaking7 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvadari
mvadari requested a balanced review from Copilot August 13, 2026 18:03
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates XLS-94 to make Dynamic MPT properties mutable by default and optionally immutable.

Changes:

  • Introduces ImmutableFlags for creation, updates, and ledger state.
  • Defines capability-setting flags and validation rules.
  • Revises examples, rationale, and security guidance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
@yinyiqian1
yinyiqian1 requested a review from mvadari August 13, 2026 22:15
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md Outdated
Comment thread XLS-0094-dynamic-MPT/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants