Skip to content

Closed-ended Vault - #587

Open
a1q123456 wants to merge 31 commits into
XRPLF:masterfrom
a1q123456:a1q123456/term-vault
Open

Closed-ended Vault#587
a1q123456 wants to merge 31 commits into
XRPLF:masterfrom
a1q123456:a1q123456/term-vault

Conversation

@a1q123456

@a1q123456 a1q123456 commented Jul 21, 2026

Copy link
Copy Markdown

High Level Overview of Change

Context of Change

Type of Change

  • New XLS Draft
  • XLS Update (changes to an existing XLS)
  • XLS Status Change (e.g., Draft → Final, Draft → Stagnant)
  • Process/Meta (changes to CONTRIBUTING.md, XLS-1, templates, etc.)
  • Infrastructure (CI, workflows, scripts, website)
  • Documentation (README updates, typo fixes)

Comment thread XLS-xxxx-term-vault/README.md Outdated
Comment thread XLS-xxxx-term-vault/README.md Outdated
Comment thread XLS-xxxx-term-vault/README.md Outdated
Comment thread XLS-xxxx-term-vault/README.md Outdated
Comment thread XLS-xxxx-term-vault/README.md Outdated
Comment thread XLS-xxxx-term-vault/README.md Outdated
Comment thread XLS-xxxx-term-vault/README.md Outdated
Comment thread XLS-xxxx-term-vault/README.md Outdated
@a1q123456
a1q123456 requested review from Tapanito and gregtatcam July 22, 2026 16:03
@github-actions

Copy link
Copy Markdown

⚠️ Self-Assigned XLS Number Warning

This PR adds a new XLS directory with a self-assigned number. XLS numbers should be assigned by the CI system using the XLS-draft-* naming convention.

Directory Self-Assigned Number
XLS-0103-term-vault 103

What to do

Please rename your directory to use the draft convention instead (e.g., XLS-draft-my-feature). An XLS number will be automatically assigned after a maintainer approves the PR.


This warning was automatically generated.

@a1q123456
a1q123456 marked this pull request as ready for review July 22, 2026 18:40
@a1q123456
a1q123456 force-pushed the a1q123456/term-vault branch from 9af7400 to 30123ca Compare July 29, 2026 20:05
Comment thread XLS-draft-0103-term-vault/README.md Outdated
Comment thread XLS-draft-closed-ended-vault/README.md
Comment thread XLS-draft-closed-ended-vault/README.md
Comment thread XLS-draft-0103-term-vault/README.md Outdated
Comment thread XLS-draft-0103-term-vault/README.md Outdated
Comment thread XLS-draft-closed-ended-vault/README.md
Comment thread XLS-draft-0103-term-vault/README.md Outdated
Comment thread XLS-0103-term-vault/README.md Outdated
Comment thread XLS-draft-closed-ended-vault/README.md
Comment thread XLS-draft-0103-term-vault/README.md Outdated
Comment thread XLS-draft-closed-ended-vault/README.md
Comment thread XLS-0103-term-vault/README.md Outdated
Comment thread XLS-draft-0103-term-vault/README.md Outdated
Comment thread XLS-draft-0103-term-vault/README.md Outdated
@a1q123456 a1q123456 changed the title Add term vault spec Closed-ended Vault Jul 30, 2026
@a1q123456
a1q123456 requested review from Tapanito and gregtatcam July 30, 2026 20:38
Comment thread XLS-draft-closed-ended-vault/README.md Outdated
Comment thread XLS-draft-closed-ended-vault/README.md Outdated
Comment thread XLS-draft-closed-ended-vault/README.md Outdated
@dangell7

dangell7 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Not 100% sure you need a RedemptionDate here but if the clients asked for that then great.

EDIT: Clients are open to Redemption Date/Fees, so are we not adding RedemptionFee to allow for early redemption penalties on both closed and open end funds.

@dangell7

dangell7 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

The subscription window implicitly starts the moment the vault is created, since now <= SubscriptionDate is treated as the Subscription phase. That ties the offering start to whenever the issuer uploads the vault, which may not be convenient for their clients. I'd make the window explicit with OfferingStart and OfferingEnd.

On naming, XLS-78 already defines Subscription ledger objects and transactions for recurring payments, so reusing the word for a vault phase will confuse tooling and docs. "Offering" avoids the collision and is the standard issuance-side term.

@Tapanito

Tapanito commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

EDIT: Clients are open to Redemption Date/Fees, so are we not adding RedemptionFee to allow for early redemption penalties on both closed and open end funds.

No we are not adding fees. Those who want to exit early can do so via the CLOB.

Regarding XLS-78, and SubscriptionDate naming, the XLS in mention is a draft proposal, that, as far as I know, is not being implemented. A naming clash with a non-existent feature shouldn't cause any issues.

@gregtatcam gregtatcam left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants