XLS-0085: align MPT lock error code with implementation (tecFROZEN -> tecLOCKED) - #601
Open
Krypto-Whitehat wants to merge 1 commit into
Open
XLS-0085: align MPT lock error code with implementation (tecFROZEN -> tecLOCKED)#601Krypto-Whitehat wants to merge 1 commit into
Krypto-Whitehat wants to merge 1 commit into
Conversation
… tecLOCKED) EscrowCreate and EscrowFinish return tecLOCKED for locked MPTs in rippled, matching the codebase wide IOU->tecFROZEN / MPT->tecLOCKED convention (see TokenHelpers.cpp). Doc only change. Fixes XRPLF#600
Krypto-Whitehat
force-pushed
the
fix-xls85-mpt-tecLOCKED
branch
from
August 15, 2026 10:57
d470701 to
36b765a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only change for XLS-0085 (Token Escrow, status Final).
The spec currently says EscrowCreate and EscrowFinish fail with
tecFROZENwhen an MPT is locked, but the rippled implementation returnstecLOCKEDin those cases.tecLOCKEDis the consistent codebase wide convention for locked MPTs (seeTokenHelpers.cpp, which branchesasset.holds<MPTIssue>() ? tecLOCKED : tecFROZEN, plus the payment, check and escrow paths).This PR aligns the two affected failure condition entries with the implementation:
tecFROZEN) and the MPT lock case (tecLOCKED)tecFROZEN->tecLOCKEDHappy to close this if maintainers prefer changing the code side instead; the linked issue tracks that question.
Fixes #600