Fix 2 remaining Code Scanning alerts + dismiss remaining false positives - #24
Merged
Conversation
Sanitize the command parameter in the timeout/error log calls, which weren't covered by the earlier fix pass (a different method in the same file).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23. Fixes the 2 log-forging alerts in ExecuteCommandWithResponse that the first pass missed (different method, same file). Also dismissed 5 more confirmed false positives on main once its post-merge CodeQL scan surfaced them (documented reasoning on each alert, same pattern as the ones dismissed in #23).