Skip to content

Fix missing Discord notification for first player join after reconnect #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xenne93 merged 1 commit into from
Aug 17, 2026
Merged

Fix missing Discord notification for first player join after reconnect #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions RustRconServerManager.Backend/Services/RconBackgroundService.Receiving.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,20 @@ await db.RconServers.Where(r => r.Id == serverId)
.ExecuteUpdateAsync(s => s
.SetProperty(r => r.LatestPlayerCount, _ => playerList.Count));

// Clear the suppress flag as soon as the first playerlist poll after a (re)connect
// completes - do this regardless of whether the list is empty, since an empty list
// (nobody online yet right after a reconnect) is still a completed sync. This used to
// be gated behind the non-empty check below, which meant that whenever nobody happened
// to be online yet at the very first poll (the common case right after a server
// restart), the flag stayed stuck "true" until a later poll found someone already
// online - silently and permanently dropping the Discord notification for whoever
// was actually the first player to join live in the meantime.
if (_suppressPlayerEvents.TryGetValue(serverId, out var suppressed) && suppressed)
{
_suppressPlayerEvents[serverId] = false;
_logger.LogInformation("[SERVER {ServerId}] Initial player sync complete - notifications enabled", serverId);
}

// If the list is empty (error or no players online, return
if (playerList == null || playerList.Count == 0)
return;
Expand Down Expand Up @@ -479,14 +493,6 @@ await db.RconServers.Where(r => r.Id == serverId)
}

await db.SaveChangesAsync();

// Clear the suppress flag after the first playerlist sync completes
// From this point on, player join/leave events will trigger notifications normally
if (_suppressPlayerEvents.TryGetValue(serverId, out var suppressed) && suppressed)
{
_suppressPlayerEvents[serverId] = false;
_logger.LogInformation("[SERVER {ServerId}] Initial player sync complete - notifications enabled", serverId);
}
}
catch (Exception ex)
{
Expand Down
Loading