Fix Discord emoji encoding, add instant purge, mandatory display names, email change - #26
Merged
Merged
Conversation
…s, email change
- Fix mojibake in Discord embed messages: the offline/online status emoji
had been mangled into a UTF-8-as-Windows-1252 double-encoding at some
point in the source file, showing as garbled characters in Discord
- Panel Settings: add a "Delete All Now" button next to the existing
older-than-X-days purge control, for immediately clearing every record
in a category on demand
- Add a mandatory Display Name, shown across the panel (navbar, moderator
lists, audit log) instead of the user's email address:
- Renamed the existing (optional) ApplicationUser.Nickname field to
DisplayName, with a migration and all call sites updated
- Required at initial admin setup
- Editable from Security Settings
- Existing accounts created before this field existed are prompted with
a blocking modal on next login until they set one
- Add email address changes from Security Settings, gated behind the
current password. Also revokes the current session and clears the auth
cookie server-side as part of the change - SecurityBindingMiddleware
re-resolves the user by their email claim on every request, so leaving
the old session's cookie in place would 401 all further requests
(including the follow-up logout call and even loading the login page)
until the browser's cookies were cleared manually
- TwModal: add an optional ZIndexClass parameter so the new mandatory
display-name gate can render above other in-app modals (e.g. the
first-run "no servers yet" welcome dialog) instead of stacking behind
them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four related changes:
All four flows were tested end-to-end in a local Docker build (fresh setup wizard, display name save + navbar update, change email + re-login, instant purge, and the legacy-account display-name gate including its stacking conflict with the existing welcome dialog).