Preserve size groups in outputs - #10
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the CIZ characteristic pipeline to preserve the precomputed size-bucket label (size_grp) through both raw and ranked outputs, so downstream consumers can segment results by size group without recomputing it.
Changes:
- Include
size_grpin the output “observation/info” columns list (OBS_VARS) so it is retained and excluded from imputation. - Exclude
size_grpfrom cross-sectional ranking/standardization by treating it as an info column instandardize().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| chars_ciz/impute_rank_output.py | Keeps size_grp in the preserved observation columns and excludes it from imputation. |
| chars_ciz/functions.py | Treats size_grp as an info column so it is not transformed into a rank_ feature and is preserved in ranked outputs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.