Skip to content

Add hash-bound SEC cell patch preview - #117

Merged
YuzeJ21 merged 1 commit into
mainfrom
codex/sec-direct-field-patch-preview
Aug 20, 2026
Merged

Add hash-bound SEC cell patch preview#117
YuzeJ21 merged 1 commit into
mainfrom
codex/sec-direct-field-patch-preview

Conversation

@YuzeJ21

@YuzeJ21 YuzeJ21 commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • add a pure inspection-only projector for the reviewed AAPL and AMD revenue and filing-date cells
  • require exact SEC packet, canonical CSV, and repository HEAD preconditions
  • prove zero schema expansion, stable row order, and unchanged unrelated cells, rows, and columns
  • add a no-write Make launcher with no apply, readiness, materialization, or provider path

Verification

  • 134 complete affected tests passed
  • Ruff and diff hygiene passed
  • independent review: Critical 0, Important 0, Minor 0
  • protected main paths: 7,315 of 7,315 byte-identical
  • post-commit packet deterministic across two runs

Boundaries

  • canonical_apply_authorized=false
  • no canonical or staged data write
  • no readiness rebuild or materialization
  • no source-rights expansion or provider fallback
  • research workflow only

@YuzeJ21
YuzeJ21 marked this pull request as ready for review August 20, 2026 18:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d23117ec2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Makefile
ifndef EXPECTED_CANONICAL_SHA256
$(error EXPECTED_CANONICAL_SHA256 is required)
endif
@PYTHONDONTWRITEBYTECODE=1 python3 -m src.sec_fundamentals_patch_preview --sec-preview-path "$(SEC_PREVIEW)" --canonical-path "$(or $(CANONICAL_PATH),data/fundamentals.csv)" --expected-sec-preview-sha256 "$(EXPECTED_SEC_PREVIEW_SHA256)" --expected-canonical-sha256 "$(EXPECTED_CANONICAL_SHA256)" --repository-head "$(shell git rev-parse HEAD)"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Require the reviewed repository hash

When the checkout has moved since the SEC packet was reviewed, this launcher substitutes the new git rev-parse HEAD value and the Python code only validates its format, so the command succeeds and records the drifted commit as if it were a satisfied precondition. This defeats the advertised hash-bound, fail-closed behavior and could let an owner approve cells projected by unreviewed code; require an externally supplied expected repository hash and compare it with the actual HEAD instead.

Useful? React with 👍 / 👎.

@YuzeJ21
YuzeJ21 merged commit 2cc4615 into main Aug 20, 2026
1 check passed
@YuzeJ21
YuzeJ21 deleted the codex/sec-direct-field-patch-preview branch August 20, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant