Skip to content

🧪 [testing improvement] Add tests for Gen5ComputeSystemRegisters.TryGetExpression - #22

Merged
ManupaKDU merged 3 commits into
mainfrom
add-tests-trygetexpression-3821128137305832918
Jul 26, 2026
Merged

🧪 [testing improvement] Add tests for Gen5ComputeSystemRegisters.TryGetExpression#22
ManupaKDU merged 3 commits into
mainfrom
add-tests-trygetexpression-3821128137305832918

Conversation

@manupawickramasinghe

Copy link
Copy Markdown
Member

🎯 What: Added tests for the TryGetExpression method within the shader IR components to verify register mapping to GLSL expressions.
📊 Coverage: Covered all known register mappings (WorkGroup X/Y/Z, ThreadGroupSize), unmatched register fallback, and null properties edge cases.
Result: Improved test coverage and verification for shader evaluation state and compute system registers.


PR created automatically by Jules for task 3821128137305832918 started by @manupawickramasinghe

Adds unit tests to verify the dictionary lookup behavior of TryGetExpression.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 26, 2026 09:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

google-labs-jules Bot and others added 2 commits July 26, 2026 10:22
Adds unit tests to verify the dictionary lookup behavior of TryGetExpression.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Adds unit tests to verify the dictionary lookup behavior of TryGetExpression.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@ManupaKDU
ManupaKDU merged commit 0aeb5a7 into main Jul 26, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants