Draft
Fix benchmarks actually measuring NoopLoggerProvider instead of configured loggers#5
Conversation
- Remove ClearProviders()/NoopLoggerProvider override from BuildLogger so each benchmark actually exercises its configured logging provider - Use NoopLoggerProvider only for the MS logger baseline benchmarks - Configure NLog with an empty LoggingConfiguration (no targets = no file I/O, but NLog pipeline is active) - Configure Log4Net with a MemoryAppender (no file I/O, Log4Net pipeline active) - Remove now-unused `using log4net.Config` and `NLogManager` alias
Copilot
AI
changed the title
[WIP] Fix BuildLogger to use NLogLoggingProvider instead of NoopLoggerProvider
Fix benchmarks actually measuring NoopLoggerProvider instead of configured loggers
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildLoggerunconditionally calledClearProviders()then injectedNoopLoggerProvider, wiping out every registered logging provider. Every benchmark — NLog, Log4Net, Serilog — was measuring identical no-op overhead, not the actual logger pipelines.Changes
BuildLogger: Remove theClearProviders()+NoopLoggerProvideroverride; let each benchmark use its own registered provider.NoopLoggerProviderexplicitly in the MS logger setup only — it's the intended noop baseline.LoadConfigurationFromFile("nlog.config")with an emptyLoggingConfiguration— NLog pipeline active, no file I/O:XmlConfiguratorfile-based config with a programmaticMemoryAppender— Log4Net pipeline active, no file I/O.using log4net.ConfigandNLogManageralias.