UN-3770 [MISC] Remove noisy tooltips from the resource list table - #2230
Conversation
Drop the always-on "Manage Co-Owners" tooltip wrapping the owner cell — it fired on every row hover and stacked on top of the ellipsis tooltip of the truncated owner email. The button keeps an aria-label so the action is still announced. Narrow the owner-name tooltip to the text actually rendered instead of the joined co-owner email list, so antd's ellipsis gating means it only appears when the name is genuinely truncated. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UpQ4upCajYZKzTFLL23cT1
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughResourceTable limits co-owner tooltip content to the visible owner name and count. The co-owner button no longer uses an Ant Design tooltip and includes visually hidden “Manage co-owners” text. ChangesResource owner display
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
chandrasekharan-zipstack
changed the title
|
| Filename | Overview |
|---|---|
| frontend/src/components/widgets/resource-table/ResourceTable.jsx | Removes noisy tooltip behavior and completes the prior accessibility fix by retaining owner details while appending action and resource context. |
| frontend/src/components/widgets/resource-table/ResourceTable.css | Adds conventional visually hidden styling for the accessible action text. |
Reviews (5): Last reviewed commit: "UN-3770 [FIX] Name the resource in the c..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Every owner button announced the same "Manage co-owners", so assistive tech users had to rebuild row context to tell the controls apart. Fold the resource name into the label. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UpQ4upCajYZKzTFLL23cT1
pk-zipstack
left a comment
pk-zipstack
left a comment
There was a problem hiding this comment.
Reviewed the single-file diff. The tooltip removal itself is sound — antd v5's EllipsisTooltip does force open={false} when the text isn't truncated, so the remaining ellipsis={{ tooltip }} usages only fire on genuine overflow, and dropping the Tooltip wrapper doesn't touch the click handler, stopPropagation, or the owner_emails fallback. Tooltip and ownerEmails both still have other users in the file, so nothing goes unused.
One issue on the new aria-label (inline), plus one scope note:
The same stacked-tooltip bug is still live in the card/grid view. frontend/src/components/widgets/card-grid-view/CardFieldComponents.jsx (OwnerFieldRow, ~L131-155) nests <Tooltip title={email}> inside <Tooltip title="Manage Co-Owners">. That inner tooltip is a plain Tooltip, not an ellipsis-gated Typography one, so both tooltips fire on every hover regardless of truncation — strictly worse than what this PR fixes in ResourceTable. That view backs the API Deployments and Pipelines pages (ApiDeploymentCardConfig.jsx, PipelineCardConfig.jsx), so users still hit the double-tooltip there. Worth folding into this PR or a follow-up, otherwise the two list surfaces behave differently.
An aria-label replaces the accessible name computed from the button's contents, so labelling the action hid the owner name and email that the Owned By column exists to convey. Move the action into a visually hidden child instead, letting the content-derived name carry both. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UpQ4upCajYZKzTFLL23cT1
Two rows owned by the same user produced identical accessible names, so tabbing between owner buttons gave nothing to tell them apart. Append the resource title, guarded so a row without one falls back to the action alone rather than reading "for undefined". Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UpQ4upCajYZKzTFLL23cT1
Frontend Lint Report (Biome)✅ All checks passed! No linting or formatting issues found. |
|
Unstract test resultsPer-group results
Critical paths
|
3 participants
What
Manage Co-Ownerstooltip that wrapped the owner cell inResourceTable.Me,user +2) instead of the joined list of every co-owner email.Why
Follow-up polish on #2208. On the resource list pages (LLMs, adapters, connectors, Prompt Studio, workflows) hovering anywhere in the Owned By cell fired the
Manage Co-Ownerstooltip on every row. When the owner's email was long enough to be truncated, antd's ellipsis tooltip fired at the same time, so two tooltips stacked on top of each other and covered the adjacent rows.The name-level tooltip listing all co-owner emails added a third source of noise for a detail the co-owner modal already shows on click.
How
<Tooltip title="Manage Co-Owners">wrapper; the owner cell is now a bare<button>carryingaria-label="Manage co-owners", so the action is still announced to screen readers and the click behaviour is unchanged.ownerTooltip(which joinedowner_emails) with the displayed`${name}${extra}`string.No change was needed for the Name, description or email tooltips: antd's
EllipsisTooltipalready forcesopen={false}when the text is not actually truncated, so those only surface on genuine overflow. The same gating now means the owner-name tooltip effectively never appears for short names.Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
No. Presentation-only change scoped to one component:
stopPropagation, and the row-click behaviour are untouched.owner_emailsis still read for the primary-owner/created_by_emailfallback — only its use as tooltip text was removed.aria-labelplus the existing hover affordance on the owner button.Database Migrations
Env Config
Related Issues or PRs
Notes on Testing
chandru-unstract-devnamespace (run 31153963693); ArgoCD sync succeeded and the platform/runner/backend health probes are returning 200.Manage Co-Ownerspopup should be gone, and the email tooltip should appear only on genuinely truncated addresses.Checklist
I have read and understood the Contribution Guidelines.