refactor(providers): reuse retired Roo identifier

[WebMad]

Summary

• make LEGACY_ROO_PROVIDER reference retiredProviderIdentifiers.roo
• preserve the existing serialized "roo" value and compatibility checks
• add focused regression coverage for Roo migration and other retired providers

Part of #944 (item 5: reuse the retired-provider registry).

Testing

• npx vitest run core/config/__tests__/routerRemoval.spec.ts core/config/__tests__/ProviderSettingsManager.spec.ts core/config/__tests__/ContextProxy.spec.ts (85 tests passed)
• pnpm --dir src exec eslint --prune-suppressions --max-warnings=0 core/config/routerRemoval.ts core/config/__tests__/routerRemoval.spec.ts
• repository pre-commit lint hook
• repository pre-push type-check hook

Summary by CodeRabbit

• Bug Fixes
  • Improved recognition of legacy Roo provider configurations.
  • Legacy Roo configurations are now downgraded while preserving custom settings.
  • Confirmed that other retired providers continue to be handled correctly.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e2f6088c-378b-45a3-87f1-4acd92341c84

📥 Commits

Reviewing files that changed from the base of the PR and between d0af4c0 and 7d18e32.

📒 Files selected for processing (2)

• src/core/config/__tests__/routerRemoval.spec.ts
• src/core/config/routerRemoval.ts

---

📝 Walkthrough

Walkthrough

The router removal logic now derives the legacy Roo provider identifier from @roo-code/types. Tests cover Roo configuration migration, preservation of custom settings, and unchanged handling of other retired providers.

Changes

Roo provider removal

Layer / File(s)	Summary
Canonical identifier and migration tests src/core/config/routerRemoval.ts, src/core/config/__tests__/routerRemoval.spec.ts	LEGACY_ROO_PROVIDER now uses retiredProviderIdentifiers.roo. Tests validate legacy Roo configuration handling, setting preservation, and no-op behavior for other retired providers.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• Zoo-Code-Org/Zoo-Code#952: Introduces the shared retired Roo provider registry consumed by this change.
• Zoo-Code-Org/Zoo-Code#1012: Also adopts retiredProviderIdentifiers.roo for Roo provider removal handling.
• Zoo-Code-Org/Zoo-Code#1165: Canonicalizes Roo provider identifiers with shared typed constants.

Suggested labels: awaiting-review

Suggested reviewers: edelauna

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the refactor to reuse the retired Roo provider identifier.
Description check	✅ Passed	The description explains the implementation, compatibility behavior, linked issue, and test results, but omits the template checklist and several optional sections.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/core/config/__tests__/routerRemoval.spec.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

src/core/config/routerRemoval.ts

ESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!