Skip to content

[Refactor] Reuse shared CustomModesManager test helpers - #1190

Merged
edelauna merged 1 commit into
mainfrom
refactor/custom-modes-manager-test-utils-0l3imnen4dykb
Aug 8, 2026
Merged

[Refactor] Reuse shared CustomModesManager test helpers#1190
edelauna merged 1 commit into
mainfrom
refactor/custom-modes-manager-test-utils-0l3imnen4dykb

Conversation

@zoomote

@zoomote zoomote Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

What changed

  • Reused the shared VS Code extension context and URI factories across the three CustomModesManager config specs.
  • Reused the shared mock reset helper for suite teardown.
  • Kept each spec's filesystem, export/import, watcher, and YAML edge-case setup local to its scenarios.

Why this change was made

This continues the incremental test-utils rollout with a small, mechanical config-test batch. It removes repeated VS Code test scaffolding without extracting behavior-specific filesystem fixtures or widening the scope to the larger import/export suite.

Impact

Test-only refactor. CustomModesManager behavior and coverage are unchanged, while the config specs now share the established test utility conventions.

@codecov

codecov Bot commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@edelauna
edelauna marked this pull request as ready for review August 8, 2026 01:02
@zoomote

zoomote Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

No code issues found.

Reviewed c71c059

@edelauna
edelauna enabled auto-merge August 8, 2026 01:09
@edelauna
edelauna added this pull request to the merge queue Aug 8, 2026
@github-actions github-actions Bot added the awaiting-review PR changes are ready and waiting for maintainer re-review label Aug 8, 2026
Merged via the queue into main with commit 2fcfe90 Aug 8, 2026
24 checks passed
@edelauna
edelauna deleted the refactor/custom-modes-manager-test-utils-0l3imnen4dykb branch August 8, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR changes are ready and waiting for maintainer re-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants