fix: repoint the eriknewton commitment link - #7
Open
widrss wants to merge 1 commit into
Open
Conversation
Comment 16970991 does not exist in discussion 1576. 16970635 is the comment carrying the commitment the key names. Verified via the GraphQL API; the field sits in context, which no signature covers. All 14 vector tests still pass. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vectors/v0/manifest.jsonpointederiknewton_commitmentat#discussioncomment-16970991, which does not exist in discussion 1576. Queried the discussion through the GraphQL API to enumerate every comment and reply:16970635is the one that carries the commitment the key names — eriknewton replying "I will PR the four missing msaleme categories ... once the v0 envelope shape is on the wire", which is exactly whatcategories_pendingtracks.Safe by construction:
contextis a sibling ofvector_ids, so no signature covers it.pytest testsis 14/14 after the edit.Mirrors the same repoint to
tests/conformance/fixtures/cross-extension-v0.jsonin the core repo (a2a-settlement#8).categories_pendinghere is already un-prefixed, so nothing else needed changing.Made with Cursor