[FIX] Copy action - #293
Open
aarnapant-sap wants to merge 2 commits into
Open
Conversation
shubhamWaghmare-sap
requested changes
Nov 4, 2025
shubhamWaghmare-sap
left a comment
shubhamWaghmare-sap
left a comment
Collaborator
There was a problem hiding this comment.
Minor refactoring changes.
| manager.add(AbapGitView.this.actionCopy); | ||
|
|
||
| // Create the sub-menu for Copy | ||
| MenuManager copySubMenu = new MenuManager("Copy"); |
Collaborator
There was a problem hiding this comment.
Externalize the string.
Comment on lines
+528
to
+541
| this.actionCopyCell = new Action("Copy Cell") { | ||
| @Override | ||
| public void run() { | ||
| copyCell(); | ||
| } | ||
| }; | ||
|
|
||
| this.actionCopyRow = new Action("Copy Row") { | ||
| @Override | ||
| public void run() { | ||
| copyRow(); | ||
| } | ||
| }; | ||
|
|
Collaborator
There was a problem hiding this comment.
Externalize both strings.
Comment on lines
+765
to
+776
| final Clipboard clipboard = new Clipboard(this.viewer.getControl().getDisplay()); | ||
| String textToCopy = null; | ||
|
|
||
| TableItem[] selection = this.viewer.getTable().getSelection(); | ||
| if (selection.length > 0 && this.focusedColumnIndex != -1) { | ||
| textToCopy = selection[0].getText(this.focusedColumnIndex); | ||
| } | ||
|
|
||
| if (textToCopy != null && !textToCopy.isEmpty()) { | ||
| clipboard.setContents(new String[] { textToCopy }, new TextTransfer[] { TextTransfer.getInstance() }); | ||
| } | ||
| clipboard.dispose(); |
Collaborator
There was a problem hiding this comment.
Copying to clipboard is common in both the copyCell & copyRow methods. Extract the logic as a separate method and use it in the copy methods.
private void copyToClipboard(String textToCopy) {
if (textToCopy == null || textToCopy.isEmpty()) return;
final Clipboard clipboard = new Clipboard(this.viewer.getControl().getDisplay());
clipboard.setContents(new String[] { textToCopy },
new TextTransfer[] { TextTransfer.getInstance() });
clipboard.dispose();
}
}
| return; // Found the column | ||
| } | ||
| } | ||
| AbapGitView.this.focusedColumnIndex = -1; |
Collaborator
There was a problem hiding this comment.
Low prio: Can extract -1 as a new constant. Say NO_COLUMN_SELECTED.
Collaborator
There was a problem hiding this comment.
Can extract the complete logic to find the selected column into a separate method. Easier to understand what's happening via the method name.
| table.addMouseListener(new MouseAdapter() { | ||
| @Override | ||
| public void mouseDown(MouseEvent e) { | ||
| Point pt = new Point(e.x, e.y); |
Collaborator
There was a problem hiding this comment.
Use full variable name wherever possible. i.e. use point instead of pt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
Previous flow:
when clicked on copyAction whole row was copied and copied text have to be truncatedNew flow: