Skip to content

fix: scope text selection and Ctrl+A to the note editor#10

Open
abdullah4tech wants to merge 1 commit into
mainfrom
fix/scope-select-all-to-editor
Open

fix: scope text selection and Ctrl+A to the note editor#10
abdullah4tech wants to merge 1 commit into
mainfrom
fix/scope-select-all-to-editor

Conversation

@abdullah4tech

@abdullah4tech abdullah4tech commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • body{user-select:none} was missing the -webkit- prefix WebKitGTK (the Linux webview Wails uses) needs to actually enforce it, so UI chrome — menu/button labels, window controls, sidebar text — was selectable/highlightable.
  • Added matching -webkit-user-select:text to the elements that should stay selectable (editor, note title, search box, find/replace inputs).
  • Ctrl+A now only ever selects the note's content: if focus isn't already inside the editor or an input field, the global keydown handler prevents the page-wide select-all and redirects focus + selection into the editor instead.

Test plan

  • make build-linux builds clean
  • Binary launches without new errors
  • Manually confirm Ctrl+A no longer highlights menu/button/window text, and still selects within the editor, note title, search box, and find/replace fields

user-select:none on body lacked the -webkit- prefix WebKitGTK needs,
so UI chrome (buttons, menus, window controls) was selectable and
Ctrl+A would select-all the whole page instead of just the note.
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • frontend/dist/index.html is excluded by !**/dist/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ffa0eb9-b73f-4393-82ae-09a114d88d81

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/scope-select-all-to-editor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant