core: update mount type for krunkit VM to virtiofs when 9p is specified - #1609
Merged
Conversation
abiosoft
approved these changes
Jul 24, 2026
Owner
|
Can you kindly sign your commits? You can check here for details. |
Signed-off-by: Kit09K <Safetyyym@gmail.com>
Kit09K
force-pushed
the
fix-krunkit-mount-type
branch
from
July 24, 2026 12:24
ceeb5a8 to
59330a7
Compare
Contributor
Author
|
Hi @abiosoft,
Thank you for reviewing my PR. I have already amended my commit to include
the Signed-off-by line and force-pushed it, but I noticed the DCO
requirement is still flagged.
Could you kindly clarify if the DCO strict policy requires me to use my
real full name (First Name + Last Name) instead of my GitHub username (
Kit09K)?
If so, I am more than happy to update my git config with my real name,
amend the commit, and push it again.
Thank you for your guidance!
ในวันที่ ศุกร์ 24 ก.ค. 2026 เวลา 20:36 Abiola Ibrahim <
***@***.***> เขียนว่า:
… ***@***.**** requested changes on this pull request.
DCO signing required
—
Reply to this email directly, view it on GitHub
<#1609?email_source=notifications&email_token=A6PRHL35TIJNPTERGLCREOT5GNQ5TA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINZXGM3DKNBVG44KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4773654578>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6PRHL5QERHO3HKR2PARD435GNQ5TAVCNFSNUABFKJSXA33TNF2G64TZHM2DAMZQGIYDKMZRHNEXG43VMU5TIOJWGYYDQNZVGIZ2C5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
abiosoft
approved these changes
Jul 24, 2026
Owner
|
The DCO is fine now :) |
Contributor
Author
|
Thank you so much for your help and for approving this PR! :)
Since I am currently an intern and still learning, I just wanted to ask for
a little bit of feedback. Does the code work as expected on your end, and
is the implementation approach correct?
Any feedback or advice you could give me would be highly appreciated to
help me improve my coding skills.
Thank you again for your time!
ในวันที่ ศุกร์ 24 ก.ค. 2026 เวลา 20:47 Abiola Ibrahim <
***@***.***> เขียนว่า:
… *abiosoft* left a comment (abiosoft/colima#1609)
<#1609 (comment)>
The DCO is fine now :)
—
Reply to this email directly, view it on GitHub
<#1609?email_source=notifications&email_token=A6PRHL2WX22UJPDEHH53LQT5GNSFPA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBXGA2TKMBQGA32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5070550007>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6PRHL4PSLPMLWYZOF7F6FT5GNSFPAVCNFSNUABFKJSXA33TNF2G64TZHM2DAMZQGIYDKMZRHNEXG43VMU5TIOJWGYYDQNZVGIZ2C5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
The code looks straightforward and correct :) Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, starting Colima with
--vm-type krunkitfails immediately if--mount-typeis not explicitly set, because the configuration defaults to9p. The krunkit driver only supportsvirtiofsorreverse-sshfs, resulting in the following fatal error:rpc error: code = Unknown desc = field mountType must be virtiofs or reverse-sshfs for krunkit driver, got 9pChanges
This PR adds the missing fallback logic in
cmd/start.go(insidesetFlagDefaults). It automatically updates themountTypetovirtiofswhenkrunkitis used and9pis currently specified.This mirrors the existing behavior that is already implemented for the
vzvmType, allowing users to start a krunkit VM smoothly without manually overriding the mount type.