Skip to content

core: update mount type for krunkit VM to virtiofs when 9p is specified - #1609

Merged
abiosoft merged 1 commit into
abiosoft:mainfrom
Kit09K:fix-krunkit-mount-type
Jul 24, 2026
Merged

core: update mount type for krunkit VM to virtiofs when 9p is specified#1609
abiosoft merged 1 commit into
abiosoft:mainfrom
Kit09K:fix-krunkit-mount-type

Conversation

@Kit09K

@Kit09K Kit09K commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Currently, starting Colima with --vm-type krunkit fails immediately if --mount-type is not explicitly set, because the configuration defaults to 9p. The krunkit driver only supports virtiofs or reverse-sshfs, resulting in the following fatal error:

rpc error: code = Unknown desc = field mountType must be virtiofs or reverse-sshfs for krunkit driver, got 9p

Changes

This PR adds the missing fallback logic in cmd/start.go (inside setFlagDefaults). It automatically updates the mountType to virtiofs when krunkit is used and 9p is currently specified.

This mirrors the existing behavior that is already implemented for the vz vmType, allowing users to start a krunkit VM smoothly without manually overriding the mount type.

@abiosoft

Copy link
Copy Markdown
Owner

Can you kindly sign your commits? You can check here for details.

@Kit09K
Kit09K force-pushed the fix-krunkit-mount-type branch from ceeb5a8 to 59330a7 Compare July 24, 2026 12:24

@abiosoft abiosoft left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO signing required

@Kit09K

Kit09K commented Jul 24, 2026 via email

Copy link
Copy Markdown
Contributor Author

@abiosoft

Copy link
Copy Markdown
Owner

The DCO is fine now :)

@Kit09K

Kit09K commented Jul 24, 2026 via email

Copy link
Copy Markdown
Contributor Author

@abiosoft

Copy link
Copy Markdown
Owner

The code looks straightforward and correct :)

Thanks.

@abiosoft
abiosoft merged commit dd3ca83 into abiosoft:main Jul 24, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants