add file transfer#3
Open
gkgoat1 wants to merge 4 commits into
Open
Conversation
KTibow
reviewed
Jun 25, 2026
| </button> | ||
| {#each launcherApps as app (app.id)} | ||
| {#if app.isInstalled() && !app.isRunning()} | ||
| <DropFile onDrop={onDrop}> |
Contributor
There was a problem hiding this comment.
can we use a window-level event listener (<svelte:window>) instead so that we don't add a layer of indentation to everything and don't need another dep
Author
There was a problem hiding this comment.
Doesn't this run in another window, so <svelte:window> targets the wrong window?
Contributor
There was a problem hiding this comment.
very good point. can add listeners in app.ts then
Author
There was a problem hiding this comment.
I ended up vendoring svelte-parts's DropFile, is that okay?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds file transfer to the Cod VM