configuration: replace $.ajax with lorisFetch#10495
Open
Montekkundan wants to merge 6 commits into
Open
Conversation
github-actions
Bot
added
Language: Javascript
Montekkundan
added
the
State: Blocked
…wrapper' into montek/restore-10336-configuration-fetch
Contributor
|
Blocked by: #10492 |
skarya22
removed
the
State: Blocked
|
|
||
| ); | ||
| if (!response.ok) { | ||
| throw {error: (data && data.error) ? data.error : text}; |
Collaborator
There was a problem hiding this comment.
Is there a reason a throw new Error(...) isn't done here?
| /** | ||
| * Display the login modal when a request returns a 401 response. | ||
| */ | ||
| function handleUnauthorized() { |
Collaborator
There was a problem hiding this comment.
duplication between handleUnauthorized in loris-scripts.js and lorisFetch is intentional/unavoidable?
skarya22
added
the
State: Needs work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces closed PR #10336, which could not be reopened because the original fork was deleted.
Previous discussion/review:
#10336