Show empty dashboard panels for fresh installs#10503
Open
Montekkundan wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
Language: Javascript
Montekkundan
force-pushed
the
montek/10426-dashboard-empty-state
branch
from
1622610 to
01890d1
Compare
skarya22
requested changes
Jun 1, 2026
Contributor
skarya22
left a comment
skarya22
left a comment
There was a problem hiding this comment.
Little cleanup. Looks good though!
Comment on lines
+383
to
+393
| <Panel | ||
| title={ | ||
| t('Recruitment', {ns: 'statistics'}) | ||
| + ' — ' | ||
| + t('Overall', {ns: 'statistics'}) | ||
| + ' | ' | ||
| + t( | ||
| 'Total Participants: {{count}}', | ||
| {ns: 'statistics', count: totalParticipants} | ||
| ) | ||
| } |
Contributor
There was a problem hiding this comment.
We can reduce some code by removing the extra details on Recruitment. We don't need the Total Participants since it is 0.
Suggested change
| <Panel | |
| title={ | |
| t('Recruitment', {ns: 'statistics'}) | |
| + ' — ' | |
| + t('Overall', {ns: 'statistics'}) | |
| + ' | ' | |
| + t( | |
| 'Total Participants: {{count}}', | |
| {ns: 'statistics', count: totalParticipants} | |
| ) | |
| } | |
| <Panel | |
| title={t('Recruitment', {ns: 'statistics'})} |
Comment on lines
+21
to
+33
| /** | ||
| * Returns the total number of participants reported by the widget endpoint. | ||
| * | ||
| * @param {object} data - Widget endpoint data | ||
| * @return {number|null} The total participant count, or null before data loads. | ||
| */ | ||
| const getTotalParticipants = (data) => { | ||
| if (!data || !data.recruitment || !data.recruitment.overall) { | ||
| return null; | ||
| } | ||
|
|
||
| return Number(data.recruitment.overall.total_recruitment); | ||
| }; |
Contributor
There was a problem hiding this comment.
Don't need this after the comment below
skarya22
added
the
State: Needs work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
No data collected yetstrings for the Statistics locale files.Testing instructions (if applicable)
Recruitment — Overall | Total Participants: 0withNo data collected yet.Study Progressionpanel also showsNo data collected yet.Link(s) to related issue(s)