Skip to content

Translate create_timepoint success button#10518

Open
Montekkundan wants to merge 2 commits into
aces:mainfrom
Montekkundan:montek/10261-create-timepoint-swal
Open

Translate create_timepoint success button#10518
Montekkundan wants to merge 2 commits into
aces:mainfrom
Montekkundan:montek/10261-create-timepoint-swal

Conversation

@Montekkundan
Copy link
Copy Markdown
Contributor

@Montekkundan Montekkundan commented Jun 2, 2026 •
edited
Loading

Brief summary of changes

  • Translates the Create Timepoint SweetAlert confirmation button through the shared loris namespace.
  • Adds missing Create Timepoint Hindi locale coverage.
  • Translates the no-cohort alert and duplicate-timepoint validation message in French, Hindi, and Japanese.
  • Keeps the existing Create Timepoint submission flow unchanged.
CleanShot 2026-06-02 at 13 09 53@2x

Testing instructions (if applicable)

  • Open Create Timepoint and switch between French, Hindi, and Japanese.
  • Submit an existing timepoint combination and confirm the duplicate-timepoint message is translated.

Link(s) to related issue(s)

@Montekkundan
Translate create_timepoint success button
f6baa5d 
Constraint: Fix only the untranslated Swal confirmation text for aces#10261.

Confidence: high

Scope-risk: narrow

Tested: target=create_timepoint npm run compile; git diff --check

Not-tested: Browser verification in a Japanese LORIS install; /var/www/loris is unavailable on this Mac.
@Montekkundan
Translate create timepoint alert actions and errors
e6cd2b9
@github-actions github-actions Bot added Language: Javascript PR or issue that update Javascript code Module: create_timepoint PR or issue related to create_timepoint module Multilingual Any tasks related to making LORIS multilingual labels Jun 2, 2026
@Montekkundan Montekkundan self-assigned this Jun 2, 2026
@skarya22 skarya22 requested a review from jeffersoncasimir June 2, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffersoncasimir jeffersoncasimir Awaiting requested review from jeffersoncasimir

At least 1 approving review is required to merge this pull request.

Assignees

@jeffersoncasimir jeffersoncasimir

Labels

Language: Javascript PR or issue that update Javascript code Module: create_timepoint PR or issue related to create_timepoint module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[publications] After submitting a new publication, SWAL is in english [create_timepoint] Swal button not translated

3 participants

@Montekkundan @jeffersoncasimir @skarya22