Fix data release translations#10521
Open
Montekkundan wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
Language: Javascript
skarya22
added
the
Passed manual tests
driusan
reviewed
Jun 8, 2026
| "Manage Permissions": "権限の管理", | ||
| "Note": "注記", | ||
| "Version names will be saved as lowercase.": "バージョン名は小文字で保存されます", | ||
| "File to upload": "アップロードするファイル", |
Collaborator
There was a problem hiding this comment.
This file (and all the other json locale ones) shouldn't be committed.. it's generated by make. It should be gitignored.
driusan
reviewed
Jun 8, 2026
| msgid "Note that the version associated with the file will also be overwritten." | ||
| msgstr "ファイルに関連付けられたバージョンも上書きされることに注意してください。" | ||
|
|
||
| msgid "Yes, I am sure!" |
Collaborator
There was a problem hiding this comment.
These both already exist in the loris namespace in the loris.pot
driusan
reviewed
Jun 8, 2026
| msgid "Upload File" | ||
| msgstr "上传文件" | ||
|
|
||
| msgid "File to upload" |
Collaborator
There was a problem hiding this comment.
This also already exists in the loris namespace
driusan
reviewed
Jun 8, 2026
| <SelectElement | ||
| name='userid' | ||
| label='User' | ||
| label={t('User', {ns: 'data_release'})} |
Collaborator
There was a problem hiding this comment.
Surprisingly "User" doesn't already exist in the loris namespace, but "Username" does.
Maybe this should be "Username" for consistency across LORIS?
@ridz1208 any thoughts?
CamilleBeau
added
the
State: Needs work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Testing instructions (if applicable)
make data_release.Link(s) to related issue(s)