Add first-class non-secret variables alongside secrets - #10
Merged
Conversation
Introduce top-level variables with disjoint ids from secrets, uniform deployment.secrets/variables maps, and connector-derived secure vs plaintext paths. Vercel drops scope.sensitive (type from kind); GitHub gains Actions Variables API support; SST rejects variables with a Linkable-focused Issue. Co-authored-by: Abhishek Chadha <achadha235@users.noreply.github.com>
CI failed on ubuntu and macos at `uv run ruff format --check .` because models.py still had a multi-line f-string that ruff collapses. Co-authored-by: Abhishek Chadha <achadha235@users.noreply.github.com>
achadha235
marked this pull request as ready for review
July 24, 2026 20:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a uniform
variablessurface so SecretSync can publish non-secret config without connector-specific deployment shapes.variables:(sameenv/allowEmptyshape as secrets); ids must not overlap withsecrets:secrets:and/orvariables:maps; sets may include either kindtype: sensitivevsencrypted(removesscope.sensitive)check_kind_support(variable)returns an actionable Issue pointing at Linkablessensitive, and connector kind support(destination, scope, kind)Breaking
Vercel
scope.sensitiveis rejected at validate. Move sensitive values underdeployment.secretsand plaintext underdeployment.variables.Tests