Skip to content

Add clear command to delete remote secrets - #16

Merged
achadha235 merged 5 commits into
mainfrom
abhi/add-clear-command
Jul 26, 2026
Merged

Add clear command to delete remote secrets#16
achadha235 merged 5 commits into
mainfrom
abhi/add-clear-command

Conversation

@achadha235

@achadha235 achadha235 commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add secretsync clear to delete all remote secrets/variables for selected deployment scopes
  • Respects --deployment / --destination; requires typing confirm clear operation
  • Skips source-secret env checks (auth still required); reuses list+delete path

Test plan

  • secretsync clear with wrong phrase exits without deletes
  • Correct phrase clears remotes for selected scopes
  • --deployment / --destination narrow the wipe

achadha235 and others added 3 commits July 26, 2026 17:08
Resolve cli.py import conflict by keeping both __version__ (version
command) and run_clear (clear command).

Co-authored-by: Abhishek Chadha <achadha235@users.noreply.github.com>
@achadha235

Copy link
Copy Markdown
Owner Author

@cursoragent please take a look at these merge conflicts

@cursor

cursor Bot commented Jul 26, 2026

Copy link
Copy Markdown

Resolved the merge conflicts with main on #16.

Conflict: only in src/secretsync/cli.py imports — this branch had run_clear, main had __version__ for the version command.

Fix: kept both:

from secretsync import __version__
from secretsync.application.apply import run_apply, run_clear

Pushed the merge commit; PR is MERGEABLE again. CLI unit tests: 12 passed.

Open in Web Open in Cursor 

@achadha235

Copy link
Copy Markdown
Owner Author

@cursoragent the CI is failing. please take a look and fix it

@cursor

cursor Bot commented Jul 26, 2026

Copy link
Copy Markdown

CI was failing on mypy (no-any-return in _clear_confirm): click.prompt is typed as Any, so the comparison wasn’t a clean bool under strict mode.

Wrapped the prompt result in str(...) so the function returns bool. Locally: mypy clean, 119 unit tests passed. Fix is pushed; CI is re-running on #16.

Open in Web Open in Cursor 

Wrap click.prompt result in str() so _clear_confirm returns bool
under strict mypy.

Co-authored-by: Abhishek Chadha <achadha235@users.noreply.github.com>
@achadha235
achadha235 merged commit a2b0ba8 into main Jul 26, 2026
2 checks passed
@achadha235
achadha235 deleted the abhi/add-clear-command branch July 26, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants