feat(advisor): render ADR deep-links in advisor output#805
Merged
Conversation
The advisor's related-ADR list now prints each ADR's deep link on its own line, so a reader can click straight through to the decision in the app. The link comes from the advisor response and is rendered verbatim; a null or empty link is skipped so the ADR still prints cleanly. The response struct previously discarded the server's per-ADR url field during deserialization. Capture it as an optional, backwards-compatible field (absent or null becomes None) so it can be rendered. Generated by the operator's software factory. City: factory-main · Agent: local-core.builder-2 On behalf of: @benw5483 Co-Authored-By: <operator-factory-bot> <factory-bot@<operator-domain>.invalid>
austinborn
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actual advisornow renders each related ADR's deep link on its own line, so a reader can click through to the decision in the app.urlfield it previously discarded during deserialization (optional and backwards-compatible: absent or null becomesNone).Test plan
cargo buildandcargo clippy -- -D warningsare clean.cargo testcovers the populated, null, and emptyurlcases in both the renderer and the deserialization path.cargo llvm-cov).