fix(enforcer): two latent bugs in doc consistency and section ordering - #367
Merged
Conversation
- DocumentConsistency.capture threw NullPointerException when a valid single-group pattern's group did not participate in the match (e.g. an optional group like proto(\d)?). Optional.of(null) blew up instead of treating the fact as absent; use Optional.ofNullable so the mismatch is reported cleanly. - MarkdownDocument.headingsInOrder collected every occurrence of a required heading while the compared "expected" list is de-duplicated, so a required section appearing twice produced a spurious "sections are out of order" failure. De-duplicate to first occurrence. Add regression tests for both. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LP9LjCJWatVErftj5NiqVP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
single-group pattern's group did not participate in the match (e.g. an
optional group like proto(\d)?). Optional.of(null) blew up instead of
treating the fact as absent; use Optional.ofNullable so the mismatch is
reported cleanly.
heading while the compared "expected" list is de-duplicated, so a required
section appearing twice produced a spurious "sections are out of order"
failure. De-duplicate to first occurrence.
Add regression tests for both.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01LP9LjCJWatVErftj5NiqVP