fix: only open browser in interactive (TTY) sessions - #12
Merged
Conversation
auth login and asa connect called open() unconditionally, launching a browser during tests and piped/non-interactive runs. Guard both on process.stdin.isTTY; the verification URL is still printed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running the unit tests opened a browser to
https://auth.adapty.io/activate?code=...on every run — theauth loginandasa connectcommands calledopen()unconditionally, so any non-interactive execution (tests, piped runs, CI) launched a browser.Change
Guard both
open()calls onprocess.stdin.isTTY === true, matching the existing interactivity check inasa-confirm.ts. In interactive terminals behavior is unchanged; in tests/pipes the browser is skipped. The verification URL is still printed in all cases, so users can open it manually.src/commands/auth/login.tssrc/commands/asa/connect.tsVerification
auth logintest passes and no longer opens a browser.