Test assignment from Katkov Ivan - #8
Open
Pseudolukian wants to merge 2 commits into
Open
Conversation
Author
eandreeva-twr
added a commit
that referenced
this pull request
Aug 11, 2026
* Document Ads Manager commands in the Developer CLI Add two pages for the `adapty asa` command topic from adapty-cli PR #8: - developer-cli-ads-manager: task-oriented guide covering prerequisites, bulk keyword operations, metrics in scripts, automation rules, and idempotent re-runs - developer-cli-ads-manager-reference: all 33 commands with arguments, flags, and accepted values, nested under the guide in api.json Written from the command source rather than the PR README, which is wrong on --period-unit casing, omits five campaigns create flags, and misses the connect --timeout flag. Retitle the existing reference to "Command reference" (slug unchanged) and narrow its scope statement. Cross-link the two surfaces from Ads Manager articles for keywords, campaigns, automations, and metrics. * Add competitors command, drop CLI skill callouts, reframe for agents - Document `asa competitors summary` from adapty-cli commit aedd248: new Competitors section in the reference, a guide section, and a cross-link from Market Intelligence. It is a subset of the dashboard feature, so both sections send the reader back for filtering and add-to-campaign. - Remove the "Using an AI assistant?" skill callout from all four Developer CLI articles. - Split "Before you start" into Prerequisites and Differences from the rest of the CLI. - Lead with agentic workflows rather than scripts, since that is the primary use case for reading metrics from the CLI. - Link the CLI from the Ads Manager hub, and finish its truncated "Get started" sentence. * Verify against CLI 0.4.0 and document the ads-manager skill Verification against the shipped package rather than the PR README corrected four things: - Ads Manager has its own pagination flags: default 100 / max 1000, not the Developer API's 20 / 100. - `product-pages sync` success semantics were stated backwards. - `orgs list` and `apps list` each return two identifiers, and the flags accept only one — passing `org_id` or `adam_id` where a UUID is expected silently matches nothing. - The list-filter matrix said "all lists", which wrongly included apps, orgs and automations. Now enumerated. Also documents behavior absent from the PR source: metrics date-window caps by grouping, the analytics budget, the automatic retry on a short Retry-After, and that a top-N question is one ordered call. Adds a page for the ads-manager AI skill with a reusable install snippet, linked from the CLI guide, the Ads Manager hub, and the AI Agent article, which it contrasts with (advisory versus acting). * Note the *.adapty.io domain allowlist requirement for Cowork Corporate Cowork workspaces restrict outbound domains, so the skill cannot reach Adapty until an administrator allowlists *.adapty.io.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Strategy on improving Adapty documentation
I will divide the work on improving the documentation into two main blocks: content work and DocOps work. Content work on the documentation to enhance user experience:
DocOps work to improve the documentation:
#includeand{{ var }}for content reuse, reducing errors, and ensuring greater consistency in the documentation.2. Write documentation on the Overview feature
I rewrote the documentation in
versioned_docs/version-3.0/overview.md, aiming to add more clarity and detail.3. Identify issues with the SDK installation flow and provide an improved version
I worked a bit on
versioned_docs/version-3.0/installation-of-adapty-sdks.md. Unfortunately, my laptop doesn’t allow me to fully install Dart, Swift, Flutter, and Android Studio to test the documentation comprehensively, so I did what I could for this task.4. Identify issues with the Server Side API and (optionally, as a bonus) provide an improved version
Here, I already have some observations:
api-secret-keyversuspublic-api-key.Overall, my impression of the documentation is mostly positive. It’s clear that the documentation is still young, and the value of many sections hasn’t been fully established yet. I hope I can be helpful, and that my experience and approach will contribute to making Adapty’s documentation even better.