Replace the Apple-vs-Adapty install gap with a standard metric set - #4
Open
KQLYYY wants to merge 1 commit into
Open
Replace the Apple-vs-Adapty install gap with a standard metric set#4KQLYYY wants to merge 1 commit into
KQLYYY wants to merge 1 commit into
Conversation
The install comparison was noise that read like a finding. It put two numbers from different attribution models and different event definitions side by side, then disclaimed that the difference meant nothing and that nobody would investigate it — while occupying a headline section in both the weekly check-in and the account-health audit. Remove it from every skill, playbook, command, doc and translation. Each of the three workflow files now carries an explicit non-goal sentence instead, and lint-workflows forbids `adapty_installs`, `absolute_gap`, `relative_gap` and the attribution disclaimer so it cannot creep back. In its place, both reporting workflows report one fixed metric set: spend, impressions, taps, avg_cpt, total_installs, total_avg_cpi, cost_per_trial and cost_per_paid. The weekly review previously requested only four metrics; the rest ride the same single `metrics overview` call, so the four-call and three-call budgets are unchanged. The linter requires all eight names in both playbooks and in the /asa-review command. CPI is Apple's own `total_avg_cpi` field, read rather than computed. It counts redownloads, and the benchmarks skill publishes spend per download under the name CPA and forbids aliasing the two — both playbooks now warn against comparing them without checking the denominator. cost_per_trial is gated on a new required input: whether the app offers a free trial. When it does not, the row is dropped and the metric is not offered as a success metric. `asa-metrics.md` is untouched — it is generated, and `adapty_installs` remains a valid CLI metric. Only the workflow built on its difference from Apple's count is gone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Apple Ads plugin 0.3.0.
1. Remove the Apple-vs-Adapty install comparison
Every review and audit ended with a section like:
It compares two numbers built on different attribution models and different event definitions, then immediately disclaims that the difference means nothing and that nobody will look into it. It reads like a finding, and it occupied a headline output section in both the weekly check-in and the account-health audit.
Removed from:
skills/apple-ads/references/playbooks/weekly-review.mdandskills/apple-ads-audit/references/playbooks/account-health.md— formula blocks, output sections, examples, gap-specific failure modes. Neither playbook requestsadapty_installsany more.skills/apple-ads-audit/SKILL.md— the## Simple install comparisonsection, the routing bullet, and the skilldescription, including the"why are Apple and Adapty installs different"trigger (replaced with"which campaigns are wasting spend").references/INDEX.md,commands/asa-audit.md,commands/asa-review.md, andbid-optimization.md, which also fetched both install counts.README.md+ both translations,docs/playbooks/README×3,examples/prompts.md,docs/IMPROVEMENT-IDEAS.md.Rather than only deleting it, each of the three workflow files now states the non-goal explicitly, and
lint-workflows.mjsforbidTextsadapty_installs,absolute_gap,relative_gapanddifferent attribution and event definitionsso it cannot return quietly.2. Give the weekly review a real metric set
weekly-review.mdrequested exactly four things:spend,total_installs,adapty_installsand one selected success metric. Impressions, taps, avg CPT, CPI, cost per trial and cost per paid were all available in the same call and none were requested.Both reporting workflows now report one fixed set, in order:
spendimpressionstapsavg_cpttotal_installstotal_avg_cpicost_per_trialcost_per_paidThe whole set rides the same single
metrics overviewcall the playbooks already made, so the weekly review's four-call budget and the audit's three-call budget are unchanged. The same set goes on the campaign-outlier call and intoaccount-health.md, so/asa-auditand/asa-reviewnow report performance identically. The linter requires all eight names in both playbooks and inasa-review.md.Two decisions worth reviewing:
total_avg_cpifield, read rather than computed. It counts redownloads. Theapple-ads-benchmarksskill publishes spend-per-download under the name CPA and explicitly forbids aliasing that to CPI, so both playbooks now warn against placing the two side by side without checking the denominator.cost_per_trialis gated on a new required input — "does the app offer a free trial?", asked before the success-metric menu. When the answer is no, the row is dropped and the metric is not offered. The linter requires that question string in both playbooks.Not changed
skills/apple-ads/references/asa-metrics.mdisGENERATEDand synced fromadaptyteam/adapty-cli.total_installsandadapty_installsstay in the metric vocabulary — they remain valid CLI metrics. Only the workflow built on their difference is gone.Verification
lint-playbooks.mjs,lint-workflows.mjs,test-cowork-preflight.mjs,lint-i18n.mjsand both manifest JSON checks pass locally — the fulllint.ymljob.adapty install,adapty_installs,absolute_gap,relative_gap,different attribution and event definitions,install comparisonandinstall gapleaves only the intentional non-goal prose, the linter's own guard strings, and the generated metric vocabulary.adapty_installs→ forbidden-behavior error; reword the free-trial gate → missing-contract error.Not verified: no end-to-end
/asa-reviewor/asa-auditrun against a live account — that needs theadaptyCLI and a connected org, so the rendered output shape is unproven in practice.🤖 Generated with Claude Code