refactor: move build config to config file - #226
Open
lidavidm wants to merge 9 commits into
Open
Conversation
lidavidm
force-pushed
the
make-config
branch
12 times, most recently
from
August 4, 2026 03:18
9813fe9 to
8fa61b8
Compare
lidavidm
requested review from
Mandukhai-Alimaa
and
a balanced review from Copilot
August 11, 2026 03:42
lidavidm
marked this pull request as ready for review
August 11, 2026 03:44
lidavidm
marked this pull request as draft
August 11, 2026 03:44
There was a problem hiding this comment.
Pull request overview
Centralizes driver build configuration in adbc-make.toml and adds cross-platform build validation.
Changes:
- Introduces typed build plans and post-build checks.
- Updates generated workflows and Pixi tasks.
- Adds Go/Rust fixtures and cross-platform tests.
Reviewed changes
Copilot reviewed 20 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/test_local.yaml |
Adds macOS, Linux, and Windows testing. |
.rat-apache |
Registers Apache-derived fixture files. |
.rat-excludes |
Excludes the generated Cargo lockfile. |
adbc_drivers_dev/generate.py |
Corrects the Azure field type. |
adbc_drivers_dev/make.py |
Loads configuration and executes build plans. |
adbc_drivers_dev/make_checks.py |
Implements binary compatibility checks. |
adbc_drivers_dev/make_config.py |
Defines build configuration and planning. |
adbc_drivers_dev/templates/pixi.toml |
Simplifies generated build tasks. |
adbc_drivers_dev/templates/test.yaml |
Uses file-based build configuration. |
pyproject.toml |
Adds Python and Windows requirements. |
tests/make/godummy/adbc-make.toml |
Configures the Go fixture. |
tests/make/godummy/module/go.mod |
Defines the fixture module. |
tests/make/godummy/module/pkg/main.go |
Provides a dummy exported driver symbol. |
tests/make/rustdummy/Cargo.lock |
Locks Rust fixture dependencies. |
tests/make/rustdummy/Cargo.toml |
Defines the Rust fixture crate. |
tests/make/rustdummy/README.md |
Documents the Rust fixture. |
tests/make/rustdummy/adbc-make.toml |
Configures the Rust fixture. |
tests/make/rustdummy/src/lib.rs |
Implements the dummy Rust driver. |
tests/test_detect_version.py |
Tests Git worktree version detection. |
tests/test_make.py |
Tests build plans and actual builds. |
tests/test_make_checks.py |
Tests post-build compatibility checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+322
to
+328
| make_env = make_config.MakeEnv( | ||
| ci=to_bool(get_var("CI", "false")), | ||
| debug=to_bool(get_var("DEBUG", "False")), | ||
| host_platform=PLATFORM, | ||
| host_architecture=normalize_arch(platform.machine()), | ||
| target_platform=target_platform(), | ||
| target_architecture=target_architecture(), |
Contributor
Author
There was a problem hiding this comment.
I don't think we need this override anymore.
Comment on lines
+484
to
+486
| docker_container = None | ||
| if config.use_docker: | ||
| docker_container = self.lang.docker_container |
Contributor
Author
There was a problem hiding this comment.
This is intentionally changed: instead of resorting to a "script" build we can instead use a normal "go" build for cases like the singlestore driver
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
lidavidm
marked this pull request as ready for review
August 11, 2026 07:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding build arguments on the command line, move most build config to a config file and simplify the CI setup.
Tested with DataFusion, Trino, and Oracle drivers.